Skip to content

Commit

Permalink
ci: remove deprecated goreview
Browse files Browse the repository at this point in the history
To prevent breakage from the goreview repo being decommissioned.

All linting now done by GolangCI-Lint.
  • Loading branch information
odsod committed Oct 31, 2024
1 parent adfb763 commit c20d75d
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions .sage/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"go.einride.tech/sage/tools/sggo"
"go.einride.tech/sage/tools/sggolangcilint"
"go.einride.tech/sage/tools/sggolicenses"
"go.einride.tech/sage/tools/sggoreview"
"go.einride.tech/sage/tools/sgmdformat"
"go.einride.tech/sage/tools/sgyamlfmt"
)
Expand All @@ -28,7 +27,7 @@ func main() {

func Default(ctx context.Context) error {
sg.Deps(ctx, ConvcoCheck, FormatMarkdown, FormatYaml, GoGenerate, GenerateTestdata)
sg.Deps(ctx, GoLint, GoReview)
sg.Deps(ctx, GoLint)
sg.Deps(ctx, GoTest)
sg.Deps(ctx, GoModTidy)
sg.Deps(ctx, GoLicenses, GitVerifyNoDiff)
Expand All @@ -45,11 +44,6 @@ func GoTest(ctx context.Context) error {
return sggo.TestCommand(ctx).Run()
}

func GoReview(ctx context.Context) error {
sg.Logger(ctx).Println("reviewing Go files...")
return sggoreview.Run(ctx)
}

func GoLint(ctx context.Context) error {
sg.Logger(ctx).Println("linting Go files...")
return sggolangcilint.Run(ctx)
Expand Down

0 comments on commit c20d75d

Please sign in to comment.