Skip to content

Commit

Permalink
fix: npm workspace tweak: align module name and folder name
Browse files Browse the repository at this point in the history
When importing as esmodule from node-client, npm tried to resolve the local
dependency on file:../schemas from common-config-loader as @eik/schemas.
Renaming should fix this.
  • Loading branch information
trygvea committed Jun 30, 2023
1 parent db30e5b commit 91e7416
Show file tree
Hide file tree
Showing 90 changed files with 21 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
CI: true
- name: check eik json schema is up to date
run: |
npm run schema:outdated --workspace=packages/schemas
npm run schema:outdated --workspace=packages/common-schemas
env:
CI: true
- name: run tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
CI: true
- name: check eik json schema is up to date
run: |
npm run schema:outdated --workspace=packages/schemas
npm run schema:outdated --workspace=packages/common-schemas
env:
CI: true
- name: run tests
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@ Note: this module is for internal eik-lib usage and may change at any time witho

### common-config-loader

Eik configuration definition and functions for loading eik configuration files, see [config-loader](./packages/config-loader/README.md)
Eik configuration definition and functions for loading eik configuration files, see [config-loader](./packages/common-config-loader/README.md)

### common-schemas

Schema and validators for the eik.json schema used by eik configuration, see [schemas](./packages/schemas/README.md)
Schema and validators for the eik.json schema used by eik configuration, see [schemas](./packages/common-schemas/README.md)

### common-utils

Utilities used by other eik-lib packages, see [utils](./packages/utils/README.md)
Utilities used by other eik-lib packages, see [utils](./packages/common-utils/README.md)

### common-validators

Misc validators/converters used for validating eik config, see [validators](./packages/validators/README.md)
Misc validators/converters used for validating eik config, see [validators](./packages/common-validators/README.md)
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@eik/common",
"workspaces": [
"packages/validators",
"packages/schemas",
"packages/utils",
"packages/config-loader"
"packages/common-validators",
"packages/common-schemas",
"packages/common-utils",
"packages/common-config-loader"
],
"devDependencies": {
"@semantic-release/changelog": "6.0.3",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
},
"license": "MIT",
"dependencies": {
"@eik/common-schemas": "file:../schemas",
"@eik/common-utils": "file:../utils",
"@eik/common-schemas": "file:../common-schemas",
"@eik/common-utils": "file:../common-utils",
"glob": "10.3.0",
"is-glob": "4.0.3",
"mime-types": "2.1.35"
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"style:check": "prettier -c .",
"style:format": "prettier -w .",
"schema:types": "json2ts ./src/eikjson.schema.json > eikjson.d.ts",
"schema:outdated": "npm run schema:types && git diff --exit-code HEAD:packages/schemas/eikjson.d.ts eikjson.d.ts",
"schema:outdated": "npm run schema:types && git diff --exit-code HEAD:packages/common-schemas/eikjson.d.ts eikjson.d.ts",
"typecheck": "tsc && cp eikjson.d.ts types",
"prepublish": "npm run typecheck",
"test": "tap --no-check-coverage",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
16 changes: 8 additions & 8 deletions release.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,28 @@ module.exports = {
'@semantic-release/npm',
{
tarballDir: 'release',
pkgRoot: 'packages/config-loader',
pkgRoot: 'packages/common-config-loader',
},
],
[
'@semantic-release/npm',
{
tarballDir: 'release',
pkgRoot: 'packages/schemas',
pkgRoot: 'packages/common-schemas',
},
],
[
'@semantic-release/npm',
{
tarballDir: 'release',
pkgRoot: 'packages/utils',
pkgRoot: 'packages/common-utils',
},
],
[
'@semantic-release/npm',
{
tarballDir: 'release',
pkgRoot: 'packages/validators',
pkgRoot: 'packages/common-validators',
},
],
[
Expand All @@ -41,10 +41,10 @@ module.exports = {
'@semantic-release/git',
{
assets: [
'packages/config-loader',
'packages/schemas',
'packages/utils',
'packages/validators',
'packages/common-config-loader',
'packages/common-schemas',
'packages/common-utils',
'packages/common-validators',
],
},
],
Expand Down

0 comments on commit 91e7416

Please sign in to comment.