Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a visualize flag to egraph.saturate for further configuration #254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orenht
Copy link

@orenht orenht commented Jan 29, 2025

Adds an option to not visualize the resulting egraph in saturate.

@orenht orenht force-pushed the add_visualization_flag branch from fd97e97 to e14e29c Compare January 29, 2025 09:52
@saulshanabrook
Copy link
Member

Thanks for this!

.saturate() is a bit silly tbh, .run() with a schedule is much more efficient if you don't want to visualize, but oh well its exposed as a top level API, so happy for this for now!

@orenht
Copy link
Author

orenht commented Jan 30, 2025

You're right, for some reason I thought that run is an inner function 😅

I guess the confusion might come from the naming, because I do want to saturate, but not necessarily display progress.

@saulshanabrook
Copy link
Member

yeah exactly, this function maybe should be renamed to saturate_and_display or something? with maybe a depreciation on the current name?

@orenht
Copy link
Author

orenht commented Feb 3, 2025

That could work :) I suggest also adding a vanilla saturation method for clarity, but up to you of course.

Do you know why the CI is failing? It doesn't seem related to the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants