Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error message when using @function in class #230

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

saulshanabrook
Copy link
Member

Addresses #229 cc @shinawy hopefully this would be more helpful?

Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #230 will not alter performance

Comparing fix-loopnest (14a7b80) with main (646f15a)

Summary

✅ 8 untouched benchmarks

Copy link
Contributor

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion.

python/egglog/egraph.py Show resolved Hide resolved
@shinawy
Copy link

shinawy commented Dec 4, 2024

@saulshanabrook Thank you, it is better now.

saulshanabrook and others added 2 commits December 5, 2024 10:08
Co-authored-by: Hameer Abbasi <2190658+hameerabbasi@users.noreply.github.com>
@saulshanabrook saulshanabrook merged commit 9bb83d4 into main Dec 5, 2024
10 checks passed
@saulshanabrook saulshanabrook deleted the fix-loopnest branch December 5, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants