Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage when not importing all from egglog #222

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix usage when not importing all from egglog #222

merged 2 commits into from
Oct 23, 2024

Conversation

saulshanabrook
Copy link
Member

closes #210

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 23, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #222 will not alter performance

Comparing no-import-star (59d5380) with main (d9f26ff)

Summary

✅ 7 untouched benchmarks

@saulshanabrook saulshanabrook marked this pull request as ready for review October 23, 2024 21:13
@saulshanabrook saulshanabrook merged commit 97a55a2 into main Oct 23, 2024
9 checks passed
@saulshanabrook saulshanabrook deleted the no-import-star branch October 23, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

You have to use * notation when importing egglog "from egglog import *"
1 participant
@saulshanabrook