Move != to function instead of method #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how you emit the
!=
egglog function. Previously, you would use the__ne__
/x !=y
method to create it; with this PR, it is moved to a standalone functionne(x).to(y)
.This allows custom classes to override
__ne__
to support custom expressions, like how, on arrays, it would return an array of booleans. It also unifies it with theeq
function, which behaves similarly.This is a breaking change, and I could have instead preserved the
__ne__
behavior on existing classes and allowed a custom operator on override. This would have been backward compatible, but I thought it was slightly more subtle. Also, for classes that have a custom__ne__
, they might also want to emit the builtin!=
function, so we would need another way of creating that as well.Happy for any feedback on this approach!