Hlm 5075 update search across services #674

syed-egov · 2024-03-12T04:52:03Z

No description provided.

…es and updated contracts accordingly

…-project and made chanegs in test controllers in productVariant projectTask projectBeneficiary projectStaff

… services and orderBy was changed to createdtime

coderabbitai · 2024-03-12T04:52:08Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

… to list

… ReadMe file

…r-by hlm-5031 The search was updated in individual and referral management…

kanishq-egov · 2024-03-12T05:14:02Z

...ealth-services-models/src/main/java/org/egov/common/models/product/ProductVariantSearch.java

@@ -29,7 +29,7 @@ public class ProductVariantSearch   {

    @JsonProperty("productId")
    @Size(min = 2, max = 64)


remove the size annotation, make sure the value inserted in any list is not null.

kanishq-egov · 2024-03-12T05:14:13Z

...h-services-models/src/main/java/org/egov/common/models/project/ProjectBeneficiarySearch.java

@@ -35,11 +35,11 @@ public class ProjectBeneficiarySearch {

    @JsonProperty("projectId")
    @Size(min=2,max=64)


remove this

kanishq-egov · 2024-03-12T05:14:51Z

...h-services-models/src/main/java/org/egov/common/models/project/ProjectBeneficiarySearch.java

@@ -35,11 +35,11 @@ public class ProjectBeneficiarySearch {

    @JsonProperty("projectId")
    @Size(min=2,max=64)
-    private String projectId = null;
+    private List<String> projectId = null;

    @JsonProperty("beneficiaryId")
    @Size(min=2,max=64)


remove this

kanishq-egov · 2024-03-12T05:15:05Z

...alth-services-models/src/main/java/org/egov/common/models/project/ProjectResourceSearch.java

@@ -31,7 +31,7 @@ public class ProjectResourceSearch {

    @JsonProperty("projectId")
    @Size(min=2,max=64)


not required

kanishq-egov · 2024-03-12T05:15:12Z

...ibraries/health-services-models/src/main/java/org/egov/common/models/project/TaskSearch.java

@@ -29,18 +29,18 @@ public class TaskSearch {

    @JsonProperty("projectId")
    @Size(min=2,max=64)


not required

kanishq-egov · 2024-03-12T05:15:26Z

...ibraries/health-services-models/src/main/java/org/egov/common/models/project/TaskSearch.java

@@ -29,18 +29,18 @@ public class TaskSearch {

    @JsonProperty("projectId")
    @Size(min=2,max=64)
-    private String projectId = null;
+    private List<String> projectId = null;

    @JsonProperty("projectBeneficiaryId")
    @Size(min=2,max=64)


not required

kanishq-egov · 2024-03-12T05:15:41Z

...ibraries/health-services-models/src/main/java/org/egov/common/models/project/TaskSearch.java


    @JsonProperty("projectBeneficiaryId")
    @Size(min=2,max=64)
-    private String projectBeneficiaryId = null;
+    private List<String> projectBeneficiaryId = null;

    @JsonProperty("clientReferenceId")
    private List<String> clientReferenceId = null;

    @JsonProperty("projectBeneficiaryClientReferenceId")
    @Size(min=2,max=64)


not required

kanishq-egov · 2024-03-12T05:15:50Z

...th-services-models/src/main/java/org/egov/common/models/stock/StockReconciliationSearch.java

@@ -33,10 +33,10 @@ public class StockReconciliationSearch {

    @JsonProperty("facilityId")
    @Size(min=2, max=64)


not required

kanishq-egov · 2024-03-12T05:15:56Z

...th-services-models/src/main/java/org/egov/common/models/stock/StockReconciliationSearch.java

@@ -33,10 +33,10 @@ public class StockReconciliationSearch {

    @JsonProperty("facilityId")
    @Size(min=2, max=64)
-    private String facilityId = null;
+    private List<String> facilityId = null;

    @JsonProperty("productVariantId")
    @Size(min=2, max=64)


not required

kanishq-egov · 2024-03-12T05:23:44Z

...libraries/health-services-models/src/main/java/org/egov/common/models/stock/StockSearch.java

@@ -37,13 +37,13 @@ public class StockSearch {

    @JsonProperty("productVariantId")
    @Size(min=2, max=64)


not required

version-fix

syed-egov added 5 commits February 23, 2024 17:49

HLM-5075 Made the necessary updates in search criterias across servic…

e5342c9

…es and updated contracts accordingly

Merge branch 'dev' into HLM-5075-update-search-across-services

ecdeac7

HLM-5075 Chnages in search criteria made in common models

6a678b0

HLM-5075 updated build-config to include health-individual and health…

467c7f2

…-project and made chanegs in test controllers in productVariant projectTask projectBeneficiary projectStaff

hlm-5031 The search was updated in individual and referral management…

54ffe2a

… services and orderBy was changed to createdtime

syed-egov requested a review from kanishq-egov March 12, 2024 04:52

syed-egov self-assigned this Mar 12, 2024

syed-egov and others added 5 commits March 12, 2024 14:14

hlm-5075 removed the size annotation from the field that were changed…

b60b166

… to list

hlm-5031 changed the OrderBy DESC from ASC

27c9529

hlm-5075 Changes made in all the searches documented in Changelog and…

6479122

… ReadMe file

Merge pull request #675 from egovernments/HLM-5031-update-search-orde…

31d59d8

…r-by hlm-5031 The search was updated in individual and referral management…

Removed size annotaton from fields that were updated to List

c2e396d

kanishq-egov previously approved these changes Mar 19, 2024

View reviewed changes

Merge branch 'dev' into HLM-5075-update-search-across-services

f9b50ac

kanishq-egov dismissed their stale review via f9b50ac March 19, 2024 13:42

kanishq-egov approved these changes Mar 19, 2024

View reviewed changes

kanishq-egov merged commit 3d452ab into dev Mar 20, 2024
8 checks passed

jagankumar-egov pushed a commit that referenced this pull request May 27, 2024

Merge pull request #674 from egovernments/version-fix

d2d3937

version-fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hlm 5075 update search across services #674

Hlm 5075 update search across services #674

syed-egov commented Mar 12, 2024

coderabbitai bot commented Mar 12, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

kanishq-egov Mar 12, 2024

kanishq-egov Mar 12, 2024

kanishq-egov Mar 12, 2024

kanishq-egov Mar 12, 2024

kanishq-egov Mar 12, 2024

kanishq-egov Mar 12, 2024

kanishq-egov Mar 12, 2024

kanishq-egov Mar 12, 2024

kanishq-egov Mar 12, 2024

kanishq-egov Mar 12, 2024

		@@ -29,7 +29,7 @@ public class ProductVariantSearch {

		@JsonProperty("productId")
		@Size(min = 2, max = 64)

		@@ -35,11 +35,11 @@ public class ProjectBeneficiarySearch {

		@JsonProperty("projectId")
		@Size(min=2,max=64)

		@@ -31,7 +31,7 @@ public class ProjectResourceSearch {

		@JsonProperty("projectId")
		@Size(min=2,max=64)

		@@ -29,18 +29,18 @@ public class TaskSearch {

		@JsonProperty("projectId")
		@Size(min=2,max=64)

		@@ -33,10 +33,10 @@ public class StockReconciliationSearch {

		@JsonProperty("facilityId")
		@Size(min=2, max=64)

		@@ -37,13 +37,13 @@ public class StockSearch {

		@JsonProperty("productVariantId")
		@Size(min=2, max=64)

Hlm 5075 update search across services #674

Hlm 5075 update search across services #674

Conversation

syed-egov commented Mar 12, 2024

coderabbitai bot commented Mar 12, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CodeRabbit Configration File (`.coderabbit.yaml`)