Console v0.3.1

[jagankumar-egov]

Summary by CodeRabbit

Based on the comprehensive summary of changes, here are the release notes:

• New Features

  • Added support for Gzip-compressed request handling
  • Enhanced localization management with cache burst functionality
  • Improved debugging capabilities with new TypeScript debug configuration

• Configuration Updates

  • Added new environment variable support for retry counts, boundary codes, and localization settings
  • Updated configuration to allow more flexible resource creation and validation

• Performance Improvements

  • Optimized target calculation and resource creation processes
  • Introduced configurable chunk sizes and wait times for localization uploads

• Bug Fixes

  • Refined error handling in various utility functions
  • Updated validation logic for campaign and microplan data

• Debugging

  • Added ability to enable debug mode with DEBUG environment variable
  • Introduced new inspection capabilities for Node.js application

[coderabbitai]

Walkthrough

This pull request introduces comprehensive changes across multiple files in the health-services/project-factory project, focusing on enhancing configuration, validation, and utility functions. The modifications span various aspects of the application, including debugging capabilities, localization, resource creation, and validation logic. Key changes include adding new configuration options, refactoring existing functions, improving error handling, and introducing more flexible validation mechanisms.

Changes

File Path	Change Summary
Dockerfile	Removed redundant comment line in command configuration
package.json	Added debug mode support with conditional script execution
src/server/api/campaignApis.ts	Removed and added functions to improve resource creation process
src/server/config/index.ts	Added multiple configuration properties for retry, boundary, and localization
src/server/utils/	Enhanced utility functions with new imports, improved error handling, and more flexible configurations
tsconfig.debug.json	New debug-specific TypeScript configuration file

Sequence Diagram

sequenceDiagram
    participant Client
    participant Server
    participant ConfigManager
    participant ResourceCreator
    participant Validator

    Client->>Server: Send Request
    Server->>ConfigManager: Load Configuration
    ConfigManager-->>Server: Return Configuration
    Server->>Validator: Validate Request
    Validator-->>Server: Validation Result
    alt Validation Successful
        Server->>ResourceCreator: Process Resource
        ResourceCreator-->>Server: Resource Created
        Server->>Client: Success Response
    else Validation Failed
        Server->>Client: Error Response
    end

Loading

Possibly related PRs

• Admin Console & microplanning Patch fixes on project factory  #1276: Changes in Dockerfile and package.json files
• Implemented locale and campaign check #1300: Modifications to genericApis.ts
• Facility Singular Creation #1302: Restructuring of campaignApis.ts
• feat: Implement facility list with inactive by default and toggle act… #1343: Introduction of usageColumnStatus constant

Suggested reviewers

• sathishp-eGov
• kavi-egov

Poem

🐰 A Rabbit's Code Refrain 🐰

In lines of config, debug takes flight,
Validators dance with newfound might,
Utility functions, sleek and bright,
Transforming code with pure delight!

Hop, hop, hurrah! The changes sing! 🎉

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Caution

Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments.

Actionable comments posted: 42

🔭 Outside diff range comments (12)

health-services/project-factory/src/server/config/models/createRequestSchema.ts (1)

Line range hint 1-42: Consider adding schema version and deprecation information

Since this schema is evolving with breaking changes, it would be helpful to:

1. Add a version field to track schema changes
2. Document the removed types in a "deprecated" section

 export const createRequestSchema = {
     "$schema": "http://json-schema.org/draft-07/schema#",
+    "$version": "0.3.1",
+    "title": "Create Request Schema",
+    "description": "Schema for validating project factory create requests",
     "type": "object",

health-services/project-factory/src/server/utils/onGoingCampaignUpdateUtils.ts (3)

Line range hint 451-452: Extract HTTP request configuration to constants.

The HTTP request URLs and paths are concatenated inline, which makes maintenance difficult and error-prone.

Consider extracting these into constants:

+const API_ENDPOINTS = {
+  PROJECT_FACILITY: {
+    DELETE: `${config.host.projectHost}${config.paths.projectFacilityDelete}`,
+    SEARCH: `${config.host.projectHost}${config.paths.projectFacilitySearch}`
+  },
+  PROJECT_STAFF: {
+    DELETE: `${config.host.projectHost}${config.paths.projectStaffDelete}`,
+    SEARCH: `${config.host.projectHost}${config.paths.projectStaffSearch}`
+  }
+} as const;

-await httpRequest(config?.host?.projectHost + config?.paths?.projectFacilityDelete, projectFacilityDeleteBody);
+await httpRequest(API_ENDPOINTS.PROJECT_FACILITY.DELETE, projectFacilityDeleteBody);

Also applies to: 453-454, 455-456

---

Line range hint 592-614: Add retry mechanism for file operations.

The file operations could fail due to network issues or temporary service unavailability.

Consider implementing a retry mechanism:

async function getFileUrlWithRetry(fileStoreId: string, tenantId: string, maxRetries = 3): Promise<string> {
  for (let attempt = 1; attempt <= maxRetries; attempt++) {
    try {
      const fileResponse = await httpRequest(
        `${config.host.filestore}${config.paths.filestore}/url`,
        {},
        { tenantId, fileStoreIds: fileStoreId },
        "get"
      );

      if (!fileResponse?.fileStoreIds?.[0]?.url) {
        throw new Error("Invalid file response");
      }
      
      return fileResponse.fileStoreIds[0].url;
    } catch (error) {
      if (attempt === maxRetries) {
        throwError("FILE", 400, "INVALID_FILE");
      }
      // Exponential backoff
      await new Promise(resolve => setTimeout(resolve, Math.pow(2, attempt) * 1000));
    }
  }
  throwError("FILE", 400, "INVALID_FILE");
}

---

Line range hint 519-557: Implement batch processing for large datasets.

The processResources function processes resources sequentially, which could be inefficient for large datasets.

Consider implementing batch processing:

async function processResourcesBatch(
  mappingObject: any,
  resources: any[],
  batchSize = 5
): Promise<void> {
  const resourcesArrayFromParentCampaign = mappingObject?.parentCampaign?.resources;
  
  // Process resources in batches
  for (let i = 0; i < resources.length; i += batchSize) {
    const batch = resources.slice(i, i + batchSize);
    await Promise.all(
      batch.map(resource => 
        processIndividualResource(mappingObject, resource, resourcesArrayFromParentCampaign)
        .catch(error => {
          logger.error(`Failed to process resource: ${resource.type}`, error);
          return null;
        })
      )
    );
  }
  
  mergeParentResources(mappingObject, resources, resourcesArrayFromParentCampaign);
}

health-services/project-factory/src/server/utils/genericUtils.ts (3)

Line range hint 1251-1298: Bulk creation logic.

1. Watch usage of var on lines 1262–1263. Switch to const or let to avoid hoisting.
2. Insert concurrency controls or progress feedback if chunk creation is time-consuming.

- var activities: any[] = [];
+ const activities: any[] = [];

---

Line range hint 1300-1345: Single facility creation.
Consider combining repeated error logic with the bulk approach. Also, watch for partial creation states if some lines fail.

🧰 Tools

🪛 Biome (1.9.4)

[error] 1319-1319: This let declares a variable that is only assigned once.

'd' is never reassigned.

Safe fix: Use const instead.

(lint/style/useConst)

---

Line range hint 1582-1582: Post-campaign search logic.
Consider caching the campaign object from earlier calls if multiple lookups happen frequently.

health-services/project-factory/src/server/utils/microplanIntergration.ts (1)

Line range hint 512-512: Replace var with let.

Using var is not recommended as it's function-scoped and can lead to hoisting issues. Use let for block-scoped variables.

-                var retry: any = config?.retryUntilResourceCreationComplete;
+                let retry: any = config?.retryUntilResourceCreationComplete;

health-services/project-factory/src/server/api/genericApis.ts (2)

Line range hint 434-474: Enhance error handling in createAndUploadFile.

Consider the following improvements:

1. Use constants for retry configuration
2. Include specific error details in the final error message

+const FILE_UPLOAD_MAX_RETRIES = 3;
+const FILE_UPLOAD_RETRY_DELAY = 5000;

 async function createAndUploadFile(
   updatedWorkbook: any,
   request: any,
   tenantId?: any
 ) {
-  let retries: any = 3;
+  let retries = FILE_UPLOAD_MAX_RETRIES;
   // Enrich metadatas
   enrichTemplateMetaData(updatedWorkbook, request);
   while (retries--) {
     try {
       // ... existing code ...
     }
     catch (error: any) {
       console.error(`Attempt failed:`, error.message);
-      await new Promise((resolve) => setTimeout(resolve, 5000));
+      await new Promise((resolve) => setTimeout(resolve, FILE_UPLOAD_RETRY_DELAY));
     }
   }
-  throw new Error("Error while uploading excel file: INTERNAL_SERVER_ERROR");
+  throw new Error(`Failed to upload excel file after ${FILE_UPLOAD_MAX_RETRIES} attempts: INTERNAL_SERVER_ERROR`);
 }

---

Line range hint 434-474: Add file type validation for secure file uploads.

The file upload functionality should validate:

1. File type/extension
2. File size limits
3. Content type headers

 async function createAndUploadFile(
   updatedWorkbook: any,
   request: any,
   tenantId?: any
 ) {
+  const MAX_FILE_SIZE = 5 * 1024 * 1024; // 5MB
+  const ALLOWED_MIME_TYPES = ['application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'];
+
   let retries: any = 3;
   // Enrich metadatas
   enrichTemplateMetaData(updatedWorkbook, request);
   while (retries--) {
     try {
       // Write the updated workbook to a buffer
       const buffer = await updatedWorkbook.xlsx.writeBuffer();
+
+      // Validate file size
+      if (buffer.length > MAX_FILE_SIZE) {
+        throw new Error('File size exceeds maximum limit');
+      }
+
+      // Validate file type
+      const fileType = await import('file-type');
+      const type = await fileType.fileTypeFromBuffer(buffer);
+      if (!type || !ALLOWED_MIME_TYPES.includes(type.mime)) {
+        throw new Error('Invalid file type');
+      }

       // Create form data for file upload
       const formData = new FormData();
       formData.append("file", buffer, "filename.xlsx");

health-services/project-factory/src/server/utils/campaignMappingUtils.ts (2)

Line range hint 512-533: Consider adding a maximum wait time for resource completion.

The current implementation might wait indefinitely if retry is set to a very high value. Consider adding a maximum total wait time or implementing an exponential backoff strategy.

+                const maxWaitTimeMs = 600000; // 10 minutes
+                const startTime = Date.now();
                 let retry: any = config?.retryUntilResourceCreationComplete;
                 while (retry--) {
+                    if (Date.now() - startTime > maxWaitTimeMs) {
+                        logger.error(`Maximum wait time exceeded for resource ${resourceDetailId}`);
+                        break;
+                    }
                     const response = await searchResourceDetailsById(resourceDetailId, messageObject);

🧰 Tools

🪛 Biome (1.9.4)

[error] 509-509: Use let or const instead of var.

A variable declared with var is accessible in the whole body of the function. Thus, the variable can be accessed before its initialization and outside the block where it is declared.
See MDN web docs for more details.
Unsafe fix: Use 'const' instead.

(lint/style/noVar)

---

[error] 510-510: Use let or const instead of var.

A variable declared with var is accessible in the whole body of the function. Thus, the variable can be accessed before its initialization and outside the block where it is declared.
See MDN web docs for more details.
Unsafe fix: Use 'const' instead.

(lint/style/noVar)

---

[error] 512-512: Use let or const instead of var.

A variable declared with var is accessible in the whole body of the function. Thus, the variable can be accessed before its initialization and outside the block where it is declared.
See MDN web docs for more details.
Unsafe fix: Use 'let' instead.

(lint/style/noVar)

---

Line range hint 595-672: Consider implementing retry mechanism for batch processing.

The processResourceOrFacilityOrUserMappingsInBatches function could benefit from a retry mechanism for failed batch operations, especially since it's handling critical resource mappings.

 async function processResourceOrFacilityOrUserMappingsInBatches(type: string, mappingArray: any, batchSize: number) {
     logger.info("Processing resource mappings in batches...");
     let promises: Promise<void>[] = [];
     let totalCreated = 0;
     let batchCount = 0;
+    const maxRetries = 3;
+    
     // ... existing code ...
     
     if (promises.length >= batchSize) {
         batchCount++;
         logger.info(`Processing batch ${batchCount} with ${promises.length} promises.`);
+        let retryCount = 0;
+        while (retryCount < maxRetries) {
             try {
                 await Promise.all(promises);
+                break;
             } catch (error) {
                 logger.error(`Batch ${batchCount} failed:`, error);
+                retryCount++;
+                if (retryCount === maxRetries) {
                     throw error;
+                }
+                logger.info(`Retrying batch ${batchCount}, attempt ${retryCount + 1}`);
+                await new Promise(resolve => setTimeout(resolve, 1000 * retryCount));
             }
+        }
         promises = [];
     }

🛑 Comments failed to post (42)

health-services/project-factory/Dockerfile (1)

34-34: 🧹 Nitpick (assertive)

Remove redundant comment.

This comment is redundant as it's stating what's already implemented in the actual CMD instruction above it.

-# Replaced by CMD ["yarn", "prod"]

health-services/project-factory/package.json (2)

13-13: ⚠️ Potential issue

Security: Restrict debug port binding

The debug port is currently bound to all network interfaces (0.0.0.0), which could expose the debugger in production environments. Consider binding to localhost instead for security.

-    "serve": "if [ \"$DEBUG\" = \"true\" ]; then node --inspect=0.0.0.0:9229 dist/index.js; else node dist/index.js; fi",
+    "serve": "if [ \"$DEBUG\" = \"true\" ]; then node --inspect=127.0.0.1:9229 dist/index.js; else node dist/index.js; fi",

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    "serve": "if [ \"$DEBUG\" = \"true\" ]; then node --inspect=127.0.0.1:9229 dist/index.js; else node dist/index.js; fi",

---

17-17: 🛠️ Refactor suggestion

Avoid modifying tsconfig.json during build

Modifying tsconfig.json during the build process could lead to race conditions in concurrent builds and makes the build non-deterministic. Consider using the --project flag instead.

-    "prod": "if [ \"$DEBUG\" = \"true\" ]; then cp tsconfig.debug.json tsconfig.json; fi && yarn build && yarn serve",
+    "prod": "yarn build --project $([ \"$DEBUG\" = \"true\" ] && echo \"tsconfig.debug.json\" || echo \"tsconfig.json\") && yarn serve",

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    "prod": "yarn build --project $([ \"$DEBUG\" = \"true\" ] && echo \"tsconfig.debug.json\" || echo \"tsconfig.json\") && yarn serve",

health-services/project-factory/src/server/config/createAndSearch.ts (1)

100-102: 🧹 Nitpick (assertive)

Consider enhancing the facility creation configuration.

The new createDetails configuration is simpler compared to other resources (e.g., user). Consider adding:

1. Rate limiting configuration
2. Error handling configuration
3. Batch size limits for bulk operations

Example enhancement:

 createDetails: {
     url: config.host.facilityHost + config.paths.facilityCreate,
-    createPath: "Facility"
+    createPath: "Facility",
+    limit: 50,  // Add batch size limit
+    retryConfig: {  // Add error handling
+        maxRetries: 3,
+        backoffMs: 1000
+    },
+    rateLimit: {  // Add rate limiting
+        requestsPerMinute: 100
+    }
 },

Committable suggestion skipped: line range outside the PR's diff.

health-services/project-factory/tsconfig.debug.json (4)

61-67: 🧹 Nitpick (assertive)

Enhance test file exclusion patterns.

The current test exclusion pattern might miss test files using different naming conventions.

     "exclude": [
         "node_modules",
-        "**/*.test.ts"
+        "**/*.test.ts",
+        "**/*.spec.ts",
+        "**/tests/**",
+        "**/__tests__/**"
     ]

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    "include": [
        "./src/**/*"
    ],
    "exclude": [
        "node_modules",
        "**/*.test.ts",
        "**/*.spec.ts",
        "**/tests/**",
        "**/__tests__/**"
    ]

🧰 Tools

🪛 Biome (1.9.4)

[error] 61-61: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 61-61: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 61-63: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 63-63: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 64-64: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 64-64: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 64-67: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

52-59: 🧹 Nitpick (assertive)

Enhance source map configuration for better debugging.

Consider enabling additional source map options to improve the debugging experience.

         "sourceMap": true,
+        "sourceRoot": "./src",
+        "inlineSourceMap": true,
+        "inlineSources": true,

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools

🪛 Biome (1.9.4)

[error] 52-52: JSON standard does not allow comments.

(parse)

---

[error] 57-57: JSON standard does not allow comments.

(parse)

---

39-51: 🧹 Nitpick (assertive)

Consider adding path aliases for improved import readability.

While the module resolution configuration is solid, you could benefit from path aliases to avoid deep relative imports.

Add path mappings:

         "baseUrl": "./",
+        "paths": {
+            "@/*": ["src/*"],
+            "@components/*": ["src/components/*"],
+            "@utils/*": ["src/utils/*"]
+        },

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

        /* Module Resolution Options */
        "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
        "baseUrl": "./", /* Base directory to resolve non-absolute module names. */
        "paths": {
            "@/*": ["src/*"],
            "@components/*": ["src/components/*"],
            "@utils/*": ["src/utils/*"]
        },
        // "rootDirs": [],                        /* List of root folders whose combined content represents the structure of the project at runtime. */
        "typeRoots": [
            "./node_modules/@types"
        ], /* List of folders to include type definitions from. */
        // "types": [],                           /* Type declaration files to be included in compilation. */
        // "allowSyntheticDefaultImports": true,  /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
        "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
        // "preserveSymlinks": true,              /* Do not resolve the real path of symlinks. */
        // "allowUmdGlobalAccess": true,          /* Allow accessing UMD globals from modules. */

🧰 Tools

🪛 Biome (1.9.4)

[error] 39-39: JSON standard does not allow comments.

(parse)

---

[error] 40-40: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 40-40: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 40-40: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 40-40: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 40-40: JSON standard does not allow comments.

(parse)

---

[error] 41-41: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 41-41: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 41-41: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 41-43: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 41-41: JSON standard does not allow comments.

(parse)

---

[error] 44-44: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 44-44: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 44-46: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 46-48: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 46-46: JSON standard does not allow comments.

(parse)

---

[error] 49-49: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 49-49: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 49-49: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 49-49: JSON standard does not allow comments.

(parse)

---

3-24: 🧹 Nitpick (assertive)

Consider modernizing the TypeScript configuration.

The current configuration uses older settings that might limit performance and features:

• Target ES5 is quite old and limits modern JavaScript features
• CommonJS modules don't support tree-shaking as effectively as ESM

Consider updating to:

-        "target": "es5",
-        "module": "commonjs",
+        "target": "es2020",
+        "module": "esnext",

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

        "skipLibCheck": true,
        /* Basic Options */
        // "incremental": true,                   /* Enable incremental compilation */
        "target": "es2020", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */
        "module": "esnext", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
        // "lib": [],                             /* Specify library files to be included in the compilation. */
        // "allowJs": true,                       /* Allow javascript files to be compiled. */
        // "checkJs": true,                       /* Report errors in .js files. */
        // "jsx": "preserve",                     /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
        // "declaration": true,                   /* Generates corresponding '.d.ts' file. */
        // "declarationMap": true,                /* Generates a sourcemap for each corresponding '.d.ts' file. */
        "sourceMap": true, /* Generates corresponding '.map' file. */
        // "outFile": "./",                       /* Concatenate and emit output to single file. */
        "outDir": "./dist/", /* Redirect output structure to the directory. */
        // "rootDir": "./",                       /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
        // "composite": true,                     /* Enable project compilation */
        // "tsBuildInfoFile": "./",               /* Specify file to store incremental compilation information */
        // "removeComments": true,                /* Do not emit comments to output. */
        // "noEmit": true,                        /* Do not emit outputs. */
        // "importHelpers": true,                 /* Import emit helpers from 'tslib'. */
        // "downlevelIteration": true,            /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
        // "isolatedModules": true,               /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */

🧰 Tools

🪛 Biome (1.9.4)

[error] 4-4: JSON standard does not allow comments.

(parse)

---

[error] 6-6: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 6-6: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 6-6: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 6-6: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 6-6: JSON standard does not allow comments.

(parse)

---

[error] 7-7: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 7-7: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 7-7: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 7-13: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 7-7: JSON standard does not allow comments.

(parse)

---

[error] 14-14: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 14-14: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 14-14: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 14-15: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 14-14: JSON standard does not allow comments.

(parse)

---

[error] 16-16: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 16-16: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 16-16: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

---

[error] 16-16: JSON standard does not allow comments.

(parse)

health-services/project-factory/src/server/utils/gzipHandler.ts (3)

1-2: 🧹 Nitpick (assertive)

Update Node.js import to use the node: protocol.

For better clarity and to follow Node.js best practices, update the zlib import to use the node: protocol.

-import * as zlib from "zlib";
+import * as zlib from "node:zlib";

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

import { Request } from "express";
import * as zlib from "node:zlib";

🧰 Tools

🪛 Biome (1.9.4)

[error] 2-2: A Node.js builtin module should be imported with the node: protocol.

Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.

(lint/style/useNodejsImportProtocol)

---

24-36: 🛠️ Refactor suggestion

Improve type safety and error handling in decompression.

The current implementation has several areas for improvement:

1. Missing type information for the parsed JSON
2. Generic error handling
3. No validation of decompressed data size

Consider this enhanced implementation:

-const decompressGzip = (gzipBuffer: Buffer): Promise<any> => {
+const decompressGzip = (gzipBuffer: Buffer): Promise<Record<string, unknown>> => {
     return new Promise((resolve, reject) => {
+        const MAX_DECOMPRESSED_SIZE = 50 * 1024 * 1024; // 50MB limit
         zlib.gunzip(gzipBuffer, (err, result) => {
-            if (err) return reject(err);
+            if (err) {
+                return reject(new Error(`Gzip decompression failed: ${err.message}`));
+            }
+            if (result.length > MAX_DECOMPRESSED_SIZE) {
+                return reject(new Error("Decompressed data exceeds size limit"));
+            }
             try {
-                resolve(JSON.parse(result.toString()));
+                const parsed = JSON.parse(result.toString());
+                if (typeof parsed !== "object" || parsed === null) {
+                    throw new Error("Invalid JSON: expected an object");
+                }
+                resolve(parsed as Record<string, unknown>);
             } catch (parseErr) {
-                reject(new Error("Invalid JSON format in decompressed data"));
+                reject(new Error(`Invalid JSON format: ${parseErr.message}`));
             }
         });
     });
 };

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

// Helper function to decompress Gzip data
const decompressGzip = (gzipBuffer: Buffer): Promise<Record<string, unknown>> => {
    return new Promise((resolve, reject) => {
        const MAX_DECOMPRESSED_SIZE = 50 * 1024 * 1024; // 50MB limit
        zlib.gunzip(gzipBuffer, (err, result) => {
            if (err) {
                return reject(new Error(`Gzip decompression failed: ${err.message}`));
            }
            if (result.length > MAX_DECOMPRESSED_SIZE) {
                return reject(new Error("Decompressed data exceeds size limit"));
            }
            try {
                const parsed = JSON.parse(result.toString());
                if (typeof parsed !== "object" || parsed === null) {
                    throw new Error("Invalid JSON: expected an object");
                }
                resolve(parsed as Record<string, unknown>);
            } catch (parseErr) {
                reject(new Error(`Invalid JSON format: ${parseErr.message}`));
            }
        });
    });
};

---

4-22: 🛠️ Refactor suggestion

Enhance error handling and memory management.

The current implementation has several areas for improvement:

1. No maximum buffer size limit could lead to memory issues
2. Generic error handling loses original error types
3. Missing cleanup in error scenarios

Consider this enhanced implementation:

 export const handleGzipRequest = async (req: Request): Promise<void> => {
     const buffers: Buffer[] = [];
+    let totalSize = 0;
+    const MAX_SIZE = 10 * 1024 * 1024; // 10MB limit
 
     // Collect data chunks from the request
     await new Promise<void>((resolve, reject) => {
-        req.on("data", (chunk: any) => buffers.push(chunk));
+        req.on("data", (chunk: Buffer) => {
+            totalSize += chunk.length;
+            if (totalSize > MAX_SIZE) {
+                reject(new Error("Payload too large"));
+                return;
+            }
+            buffers.push(chunk);
+        });
         req.on("end", resolve);
         req.on("error", reject);
     });
 
     // Concatenate and decompress the data
     const gzipBuffer = Buffer.concat(buffers);
     try {
         const decompressedData = await decompressGzip(gzipBuffer);
         req.body = decompressedData; // Assign the parsed data to req.body
     } catch (err: any) {
-        throw new Error(`Failed to process Gzip data: ${err.message}`);
+        throw err; // Preserve original error
     }
 };

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

export const handleGzipRequest = async (req: Request): Promise<void> => {
    const buffers: Buffer[] = [];
    let totalSize = 0;
    const MAX_SIZE = 10 * 1024 * 1024; // 10MB limit

    // Collect data chunks from the request
    await new Promise<void>((resolve, reject) => {
        req.on("data", (chunk: Buffer) => {
            totalSize += chunk.length;
            if (totalSize > MAX_SIZE) {
                reject(new Error("Payload too large"));
                return;
            }
            buffers.push(chunk);
        });
        req.on("end", resolve);
        req.on("error", reject);
    });

    // Concatenate and decompress the data
    const gzipBuffer = Buffer.concat(buffers);
    try {
        const decompressedData = await decompressGzip(gzipBuffer);
        req.body = decompressedData; // Assign the parsed data to req.body
    } catch (err: any) {
        throw err; // Preserve original error
    }
};

health-services/project-factory/src/server/utils/middlewares/requestMiddleware.ts (3)

44-48: 🧹 Nitpick (assertive)

Improve error handling type safety.

The catch block should include proper typing for the error object.

   }
-  catch (error) {
+  catch (error: unknown) {
     // If an error occurs during validation process, handle the error using errorResponder function
     errorResponder(error, req, res);
   }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

  }
  catch (error: unknown) {
    // If an error occurs during validation process, handle the error using errorResponder function
    errorResponder(error, req, res);
  }

---

29-31: 🛠️ Refactor suggestion

Add error handling for gzip processing.

The gzip handling block should include proper error handling to maintain consistency with the middleware's error handling pattern.

     if (contentType === 'application/gzip') {
-      await handleGzipRequest(req);
+      try {
+        await handleGzipRequest(req);
+      } catch (err: any) {
+        let e = Object.assign(err, { 
+          status: err.status || 400,
+          code: err.code || "INVALID_GZIP_DATA"
+        });
+        errorResponder(e, req, res, e.status);
+        return;
+      }
     }

Committable suggestion skipped: line range outside the PR's diff.

---

22-24: 🧹 Nitpick (assertive)

Simplify content-type checking logic.

The current content-type checking logic is complex and hard to read. Consider using a more maintainable approach.

-    if (!contentType || !contentType.split(';').map(part => part.trim()).includes('application/json') && !contentType.split(';').map(part => part.trim()).includes('application/gzip')) {
-      let e: any = new Error("Unsupported Media Type: Content-Type should be 'application/json' or 'application/gzip'");
+    const supportedTypes = ['application/json', 'application/gzip'];
+    const requestType = contentType?.split(';')[0].trim();
+    if (!contentType || !supportedTypes.includes(requestType)) {
+      let e: any = new Error(`Unsupported Media Type: Content-Type should be one of: ${supportedTypes.join(', ')}`);
       e = Object.assign(e, { status: 415, code: "UNSUPPORTED_MEDIA_TYPE" });
       errorResponder(e, req, res, 415)
       return;
     }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    const supportedTypes = ['application/json', 'application/gzip'];
    const requestType = contentType?.split(';')[0].trim();
    if (!contentType || !supportedTypes.includes(requestType)) {
      let e: any = new Error(`Unsupported Media Type: Content-Type should be one of: ${supportedTypes.join(', ')}`);
      e = Object.assign(e, { status: 415, code: "UNSUPPORTED_MEDIA_TYPE" });
      errorResponder(e, req, res, 415)
      return;
    }

health-services/project-factory/src/server/utils/onGoingCampaignUpdateUtils.ts (3)

82-82: ⚠️ Potential issue

Fix unsafe optional chaining that could lead to TypeError.

The current implementation has an unsafe optional chaining that could throw a TypeError if it short-circuits with 'undefined':

const originalHeaders = type === config?.facility?.facilityType ? [config?.facility?.facilityCodeColumn, ...schema?.columns] : schema?.columns;

Apply this fix to safely handle undefined values:

-const originalHeaders = type === config?.facility?.facilityType ? [config?.facility?.facilityCodeColumn, ...schema?.columns] : schema?.columns;
+const originalHeaders = type === config?.facility?.facilityType && config?.facility?.facilityCodeColumn 
+  ? [config.facility.facilityCodeColumn, ...(schema?.columns ?? [])] 
+  : (schema?.columns ?? []);

🧰 Tools

🪛 Biome (1.9.4)

[error] 82-82: Unsafe usage of optional chaining.

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

(lint/correctness/noUnsafeOptionalChaining)

---

79-81: 🛠️ Refactor suggestion

Add type annotations for better type safety.

The function parameters lack proper TypeScript type annotations, which could lead to runtime errors.

Apply this fix to add type safety:

-function modifyProcessedSheetData(type: any, sheetData: any, schema: any, localizationMap?: any) {
+interface Schema {
+  columns: string[];
+}
+
+function modifyProcessedSheetData(
+  type: string,
+  sheetData: Record<string, unknown>[],
+  schema: Schema,
+  localizationMap?: Record<string, string>
+) {

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

interface Schema {
  columns: string[];
}

function modifyProcessedSheetData(
  type: string,
  sheetData: Record<string, unknown>[],
  schema: Schema,
  localizationMap?: Record<string, string>
) {
  if (!sheetData || sheetData.length === 0) return [];

---

36-38: 🛠️ Refactor suggestion

Improve error handling for array operations.

The function assumes that the resources array contains valid objects with type and createResourceId properties.

Apply this fix to add proper error handling:

-  return resources
-    .filter((item: any) => item.type === processedType)
-    .map((item: any) => item.createResourceId);
+  return (resources ?? [])
+    .filter((item: any): item is { type: string; createResourceId: string } => 
+      item && typeof item.type === 'string' && 
+      item.type === processedType && 
+      typeof item.createResourceId === 'string'
+    )
+    .map(item => item.createResourceId);

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

  return (resources ?? [])
    .filter((item: any): item is { type: string; createResourceId: string } => 
      item && typeof item.type === 'string' && 
      item.type === processedType && 
      typeof item.createResourceId === 'string'
    )
    .map(item => item.createResourceId);

health-services/project-factory/src/server/validators/microplanValidators.ts (1)

221-226: 🧹 Nitpick (assertive)

Potential refactor for lat-long validation.
This logic mirrors validateLatLongForMicroplanCampaigns. Consider extracting shared behavior into a helper function to avoid duplication and improve maintainability.

health-services/project-factory/src/server/utils/genericUtils.ts (9)

464-476: 🧹 Nitpick (assertive)

Commented-out dropdown code.
If you plan to reactivate this logic soon, add a TODO note. Otherwise, removing dead code might simplify maintenance.

---

528-528: 🧹 Nitpick (assertive)

Check schema usage for facility generation.
Loading schema for facility columns is a good approach. Consider caching if repeated calls degrade performance.

---

730-738: 🧹 Nitpick (assertive)

Mixed approach to dropdown logic.
You have partially commented-out code for setDropdownFromSchema but actively calling handledropdownthings. Consider standardizing or removing the old references.

---

820-820: 🧹 Nitpick (assertive)

New debug log.
logger.info("hiddenColumns", hiddenColumns) helps track usage of hidden columns. Confirm log verbosity is acceptable.

---

857-863: 🧹 Nitpick (assertive)

Consistent approach for user dropdown logic.
Similar to facility logic, consider removing commented-out code or unifying it under a single function call if needed.

---

1014-1014: 🧹 Nitpick (assertive)

Commented-out logic for schema.
If dropping partial code is safe, removing it may reduce confusion. Otherwise, mark as TODO.

---

1088-1088: 🧹 Nitpick (assertive)

Logging and rethrowing errors.
Capturing detail in handleGenerateError is valuable. Ensure no sensitive info is logged.

---

1319-1319: 🧹 Nitpick (assertive)

Use const for 'd'.
Static analysis flags you’re declaring variable d once at line 1319. Change it to const to avoid confusion and adhere to best practices.

- let d of data
+ const d of data

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    for (const d of data) {

🧰 Tools

🪛 Biome (1.9.4)

[error] 1319-1319: This let declares a variable that is only assigned once.

'd' is never reassigned.

Safe fix: Use const instead.

(lint/style/useConst)

---

854-855: 🛠️ Refactor suggestion

Use const instead of let.
receivedDropdowns is never reassigned. This aligns with the static analysis hint.

- let receivedDropdowns = request.body?.dropdowns;
+ const receivedDropdowns = request.body?.dropdowns;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

  const receivedDropdowns = request.body?.dropdowns;
  logger.info("started adding dropdowns in user", JSON.stringify(receivedDropdowns))

🧰 Tools

🪛 Biome (1.9.4)

[error] 854-854: This let declares a variable that is only assigned once.

'receivedDropdowns' is never reassigned.

Safe fix: Use const instead.

(lint/style/useConst)

health-services/project-factory/src/server/validators/campaignValidators.ts (3)

168-168: 🧹 Nitpick (assertive)

Typo fix suggested.
Change "genric" to "generic".

- // validate target columns which are not required but has data present in those columns for genric camapign types
+ // validate target columns which are not required but has data present in those columns for generic campaign types

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

        // validate target columns which are not required but has data present in those columns for generic campaign types 

---

728-729: 🧹 Nitpick (assertive)

Replace var with block-scoped declaration.

- var active = activeColumnName ? data?.[activeColumnName] : usageColumnStatus.active;
+ let active = activeColumnName ? data?.[activeColumnName] : usageColumnStatus.active;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

        let active = activeColumnName ? data?.[activeColumnName] : usageColumnStatus.active;
        if (active == usageColumnStatus.active) {

🧰 Tools

🪛 Biome (1.9.4)

[error] 728-728: Use let or const instead of var.

A variable declared with var is accessible in the whole body of the function. Thus, the variable can be accessed before its initialization and outside the block where it is declared.
See MDN web docs for more details.
Unsafe fix: Use 'const' instead.

(lint/style/noVar)

---

98-100: 🛠️ Refactor suggestion

Avoid using hasOwnProperty from the target object.
Use the Object.hasOwn() method or the 'key' in object operator for safer checks:

- const targetColumnsToValidate = isGenericType ? localizedTargetColumnNames.filter((column: string) =>
-   boundaryData.some((row: any) => row.hasOwnProperty(column) && row[column] !== null && row[column] !== undefined)
- ) : localizedTargetColumnNames;
+ const targetColumnsToValidate = isGenericType ? localizedTargetColumnNames.filter((column: string) =>
+   boundaryData.some((row: any) => Object.hasOwn(row, column) && row[column] !== null && row[column] !== undefined)
+ ) : localizedTargetColumnNames;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

                const targetColumnsToValidate = isGenericType ? localizedTargetColumnNames.filter((column: string) =>
                    boundaryData.some((row: any) => Object.hasOwn(row, column) && row[column] !== null && row[column] !== undefined)
                ) : localizedTargetColumnNames;

🧰 Tools

🪛 Biome (1.9.4)

[error] 99-99: Do not access Object.prototype method 'hasOwnProperty' from target object.

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

(lint/suspicious/noPrototypeBuiltins)

health-services/project-factory/src/server/utils/campaignUtils.ts (6)

2369-2369: 🧹 Nitpick (assertive)

Use Number.parseInt instead of the global parseInt.

- const targetNo = parseInt(codesTargetMapping[boundaryCode][beneficiaryType], 10);
+ const targetNo = Number.parseInt(codesTargetMapping[boundaryCode][beneficiaryType], 10);

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

      const targetNo = Number.parseInt(codesTargetMapping[boundaryCode][beneficiaryType], 10); // Ensure numeric conversion

🧰 Tools

🪛 Biome (1.9.4)

[error] 2369-2369: Use Number.parseInt instead of the equivalent global.

ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.parseInt instead.

(lint/style/useNumberNamespace)

---

2364-2364: 🧹 Nitpick (assertive)

Use const for targets since it's never reassigned.

- let targets: any[] = [];
+ const targets: any[] = [];

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    const targets: any[] = [];

🧰 Tools

🪛 Biome (1.9.4)

[error] 2364-2364: This let declares a variable that is only assigned once.

'targets' is never reassigned.

Safe fix: Use const instead.

(lint/style/useConst)

---

1709-1709: 🧹 Nitpick (assertive)

Use const instead of let for a never-reassigned variable.

- let totalTargetValue: any = {};
+ const totalTargetValue: any = {};

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    const totalTargetValue: any = {};

🧰 Tools

🪛 Biome (1.9.4)

[error] 1709-1709: This let declares a variable that is only assigned once.

'totalTargetValue' is never reassigned.

Safe fix: Use const instead.

(lint/style/useConst)

---

3049-3049: 🧹 Nitpick (assertive)

Use const for rowData since it's never reassigned.

- let rowData: any = { [codeColumnName]: row[codeColumnName] };
+ const rowData: any = { [codeColumnName]: row[codeColumnName] };

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    const rowData: any = { [codeColumnName]: row[codeColumnName] };

🧰 Tools

🪛 Biome (1.9.4)

[error] 3049-3049: This let declares a variable that is only assigned once.

'rowData' is never reassigned.

Safe fix: Use const instead.

(lint/style/useConst)

---

2425-2425: 🧹 Nitpick (assertive)

Avoid using the delete operator for performance reasons.

- delete request.body?.boundariesCombined;
+ request.body.boundariesCombined = undefined;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    request.body.boundariesCombined = undefined;

🧰 Tools

🪛 Biome (1.9.4)

[error] 2425-2425: Avoid the delete operator which can impact performance.

(lint/performance/noDelete)

---

1717-1717: 🛠️ Refactor suggestion

Avoid using hasOwnProperty from the target object.

- if (childTargetValue.hasOwnProperty(key)) {
+ if (Object.hasOwn(childTargetValue, key)) {
    totalTargetValue[key] = (totalTargetValue[key] || 0) + childTargetValue[key];
}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

        if (Object.hasOwn(childTargetValue, key)) {

🧰 Tools

🪛 Biome (1.9.4)

[error] 1717-1717: Do not access Object.prototype method 'hasOwnProperty' from target object.

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

(lint/suspicious/noPrototypeBuiltins)

health-services/project-factory/src/server/controllers/localisationController/localisation.controller.ts (1)

88-98: 🛠️ Refactor suggestion

Add error handling to the cacheBurst method.

The method should include try-catch block to handle potential HTTP request failures.

Apply this diff to add error handling:

  public cacheBurst = async () => {
    logger.info(`Calling localization cache burst api`);
+   try {
      const RequestInfo = defaultRequestInfo;
      const requestBody = {
        RequestInfo
      }
      await httpRequest(
        this.localizationHost + config.paths.cacheBurst,
        requestBody)
+   } catch (error: any) {
+     logger.error(`Error in cache burst: ${error.message}`);
+     throw new Error(`Failed to burst cache: ${error.message}`);
+   }
  };

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

  public cacheBurst = async (
  ) => {
    logger.info(`Calling localization cache burst api`);
    try {
      const RequestInfo = defaultRequestInfo;
      const requestBody = {
        RequestInfo
      }
      await httpRequest(
        this.localizationHost + config.paths.cacheBurst,
        requestBody)
    } catch (error: any) {
      logger.error(`Error in cache burst: ${error.message}`);
      throw new Error(`Failed to burst cache: ${error.message}`);
    }
  };

health-services/project-factory/src/server/config/index.ts (2)

22-22: 🛠️ Refactor suggestion

Add validation for retryUntilResourceCreationComplete.

The value should be validated to ensure it's a positive number.

Apply this diff:

-  retryUntilResourceCreationComplete:process.env.RETRY_TILL_RESOURCE_CREATION_COMPLETES || 100,
+  retryUntilResourceCreationComplete: (() => {
+    const value = Number.parseInt(process.env.RETRY_TILL_RESOURCE_CREATION_COMPLETES || "100", 10);
+    if (isNaN(value) || value <= 0) {
+      console.warn("Invalid RETRY_TILL_RESOURCE_CREATION_COMPLETES value, using default: 100");
+      return 100;
+    }
+    return value;
+  })(),

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

  retryUntilResourceCreationComplete: (() => {
    const value = Number.parseInt(process.env.RETRY_TILL_RESOURCE_CREATION_COMPLETES || "100", 10);
    if (isNaN(value) || value <= 0) {
      console.warn("Invalid RETRY_TILL_RESOURCE_CREATION_COMPLETES value, using default: 100");
      return 100;
    }
    return value;
  })(),

---

102-103: 🧹 Nitpick (assertive)

Use Number.parseInt instead of global parseInt.

For consistency with ES2015, use the Number namespace version.

Apply this diff:

-    localizationWaitTimeInBoundaryCreation: parseInt(process.env.LOCALIZATION_WAIT_TIME_IN_BOUNDARY_CREATION || "30000"),
-    localizationChunkSizeForBoundaryCreation: parseInt(process.env.LOCALIZATION_CHUNK_SIZE_FOR_BOUNDARY_CREATION || "2000"),
+    localizationWaitTimeInBoundaryCreation: Number.parseInt(process.env.LOCALIZATION_WAIT_TIME_IN_BOUNDARY_CREATION || "30000", 10),
+    localizationChunkSizeForBoundaryCreation: Number.parseInt(process.env.LOCALIZATION_CHUNK_SIZE_FOR_BOUNDARY_CREATION || "2000", 10),

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    localizationWaitTimeInBoundaryCreation: Number.parseInt(process.env.LOCALIZATION_WAIT_TIME_IN_BOUNDARY_CREATION || "30000", 10),
    localizationChunkSizeForBoundaryCreation: Number.parseInt(process.env.LOCALIZATION_CHUNK_SIZE_FOR_BOUNDARY_CREATION || "2000", 10),

🧰 Tools

🪛 Biome (1.9.4)

[error] 102-102: Use Number.parseInt instead of the equivalent global.

ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.parseInt instead.

(lint/style/useNumberNamespace)

---

[error] 103-103: Use Number.parseInt instead of the equivalent global.

ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.parseInt instead.

(lint/style/useNumberNamespace)

health-services/project-factory/src/server/utils/excelUtils.ts (2)

127-131: 🛠️ Refactor suggestion

Add error handling for missing or invalid data.

Consider adding validation and error handling for:

• Missing or invalid request info
• Missing or invalid campaign ID

 export function enrichTemplateMetaData(updatedWorkbook : any, request : any ){
+  if (!updatedWorkbook) {
+    throwError("FILE", 400, "INVALID_WORKBOOK", "Workbook is required for metadata enrichment.");
+  }
   if(request?.body?.RequestInfo && request?.query?.campaignId){
     updatedWorkbook.keywords = `${getLocaleFromRequestInfo(request?.body?.RequestInfo)}#${request?.query?.campaignId}`
+  } else {
+    throwError("FILE", 400, "INVALID_REQUEST", "Request info and campaign ID are required for metadata enrichment.");
   }
 }

Committable suggestion skipped: line range outside the PR's diff.

---

377-393: 🛠️ Refactor suggestion

Add error handling for missing usage column.

Consider adding validation and error handling when the usage column is not found in the worksheet.

 export function enrichUsageColumnForFacility(worksheet: any, localizationMap: any) {
+  if (!worksheet || !localizationMap) {
+    throwError("FILE", 400, "INVALID_INPUT", "Worksheet and localization map are required.");
+  }
   const configType = "facility";
   const usageColumn = getLocalizedName(createAndSearch[configType]?.activeColumnName, localizationMap);
   if (usageColumn) {
     const usageColumnIndex = getColumnIndexByHeader(worksheet, usageColumn);
+    if (usageColumnIndex === -1) {
+      throwError("FILE", 400, "COLUMN_NOT_FOUND", `Usage column '${usageColumn}' not found in the worksheet.`);
+    }
     if (usageColumnIndex !== -1) {
       worksheet?.eachRow((row: any, rowNumber: number) => {
         if (rowNumber === 1) return; // Skip header row
         const cell = row.getCell(usageColumnIndex);
         // Only change the value if it is empty or null
         if (!cell.value) {
           cell.value = usageColumnStatus.inactive;
         }
       });
     }
   }
 }

Committable suggestion skipped: line range outside the PR's diff.

health-services/project-factory/src/server/utils/campaignMappingUtils.ts (1)

512-512: ⚠️ Potential issue

Replace var with let for block-scoped variable declaration.

Using var makes the variable accessible in the whole function body, which could lead to unexpected behavior. Use let instead to properly scope the variable.

-                var retry: any = config?.retryUntilResourceCreationComplete;
+                let retry: any = config?.retryUntilResourceCreationComplete;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

                let retry: any = config?.retryUntilResourceCreationComplete;

🧰 Tools

🪛 Biome (1.9.4)

[error] 512-512: Use let or const instead of var.

A variable declared with var is accessible in the whole body of the function. Thus, the variable can be accessed before its initialization and outside the block where it is declared.
See MDN web docs for more details.
Unsafe fix: Use 'let' instead.

(lint/style/noVar)