Merge pull request #1329 from egovernments/HCMPRE-1817

HCMPRE:1817 - Bug Fix - validating plan employee assignments only for active update calls
egovernments · Jan 9, 2025 · 1ba656a · 1ba656a
2 parents bcd3ade + 518c1cf
commit 1ba656a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/...s/plan-service/src/main/java/digit/service/validator/PlanEmployeeAssignmentValidator.java b/...s/plan-service/src/main/java/digit/service/validator/PlanEmployeeAssignmentValidator.java
@@ -317,8 +317,9 @@ public void validateUpdate(PlanEmployeeAssignmentRequest request) {
         // Validate if Plan employee assignment exists
         validatePlanEmployeeAssignmentExistance(planEmployeeAssignment);
 
-        // Validate campaign id and employee jurisdiction
-        validateCampaignDetails(planConfigurations.get(0).getCampaignId(), rootTenantId, request);
+        // Validate campaign id and employee jurisdiction for active records
+        if(planEmployeeAssignment.getActive())
+            validateCampaignDetails(planConfigurations.get(0).getCampaignId(), rootTenantId, request);
 
     }