Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20 #597

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 26, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Sep 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.40%. Comparing base (01e5f14) to head (2de079b).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   72.47%   73.40%   +0.93%     
==========================================
  Files          52       54       +2     
  Lines         821      861      +40     
  Branches      169      191      +22     
==========================================
+ Hits          595      632      +37     
- Misses        216      219       +3     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@UsamaSadiq UsamaSadiq merged commit 131b6c6 into master Oct 2, 2024
7 checks passed
@UsamaSadiq UsamaSadiq deleted the bilalqamar95/node20-upgrade-2 branch October 2, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants