Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Russia from countries in edit profile section #78

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

saeedbashir
Copy link

@saeedbashir saeedbashir commented Sep 12, 2024

This PR removes Russia from countries in the edit profile section.

How to test the PR:
As for most users, the country picker in edit profile will be disabled because of requires_parental_consent so you can test the PR by passing enabled: true to the countries picker.

This is how the screen will look for users who selected Russia as a country without parental consent. This is how the screen will look for users who selected Russia as their country and parental consent is required.
Simulator Screenshot - iPhone 15 Pro - 2024-09-12 at 10 27 56 Simulator Screenshot - iPhone 15 Pro - 2024-09-12 at 10 33 53

@rnr
Copy link
Collaborator

rnr commented Sep 12, 2024

Just Note that we also have a country on the registration screen, but this should be a backend ticket since we get the list of countries via the API.

@saeedbashir
Copy link
Author

Just Note that we also have a country on the registration screen, but this should be a backend ticket since we get the list of countries via the API.

Yes, that will be handled by the server side.

Copy link

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Russia is removed from countries list but user can able to select Russian language. Is it acceptable?
Simulator Screenshot - iPhone 15 - 2024-09-13 at 16 18 22

@rnr
Copy link
Collaborator

rnr commented Sep 13, 2024

Russia is removed from countries list but user can able to select Russian language. Is it acceptable? Simulator Screenshot - iPhone 15 - 2024-09-13 at 16 18 22

@shafqat-muneer People speak Russian not only in Russia. So I believe it's ok.

Copy link

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saeedbashir saeedbashir merged commit 2b4c4b1 into 2U/develop Sep 16, 2024
3 checks passed
@saeedbashir saeedbashir deleted the saeed/LEARNER-10214 branch September 16, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants