fix: shift due dates banner overlap #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
approved these changes
Jul 29, 2024
saeedbashir
reviewed
Jul 30, 2024
Comment on lines
+191
to
+193
| if viewModel.selection != .profile { | ||
| controller.navigationController?.setNavigationBarHidden(true, animated: false) | ||
| } |
There was a problem hiding this comment.
@forgotvas Is this change related to the mentioned issue?
There was a problem hiding this comment.
that change related to profile icon issue on profile tab on iOS 15 it disappears when you go to settings and then go back to profile. So just fixed in that PR too. Added to description.
There was a problem hiding this comment.
I guess the issue is also with the parsing, app is expecting, "account_privacy": "private" but server is returning "account_privacy": "PRIVATE".
Can you look into it under the same PR or should create a separate ticket for it.
Credentials: rtester97/Fedx1234
saeedbashir
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[iOS] The loading indicator overlaps “Shift due dates” button openedx#419
How it works now:
Simulator.Screen.Recording.-.iPhone.15.-.2024-07-29.at.21.18.12.mp4
Also that PR contains fix for profile icon issue on profile tab on iOS 15 it disappears when you go to settings and then go back to profile