Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear cookies by logout #44

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix: clear cookies by logout #44

merged 1 commit into from
Jul 26, 2024

Conversation

rnr
Copy link
Collaborator

@rnr rnr commented Jul 25, 2024

This PR fixes issue:

Pre-Login Experience > Create account button is not tapable

"when a user register with an already linked socail account then the user gets logged in, after signing out 
and going back to the register screen there is no password field and the user is unable to create an account

Steps to reproduce:
1- Register with an already linked account
2- Sign out
3- Go back to the register screeen 
4- Notice the password field will be missing 
5- Notice the user will be unable to create a new account as the create account button is not tapable "

To fix this issue I clear all cookies by logout

Copy link

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rnr rnr merged commit 97ceb35 into 2U/develop Jul 26, 2024
3 checks passed
@rnr rnr deleted the clear-cookies-by-logout branch July 26, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants