Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: highlight selected subtile - transcript #33

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

saeedbashir
Copy link

This PR address the issue Videos > Transcripts are not highlighted while the video is playing.

@rnr
Copy link
Collaborator

rnr commented Jul 22, 2024

@saeedbashir do you think it's highlighted enough for dark mode? (for light mode we have a bit different textPrimary and textSecondary but for dark they both are white)?

@saeedbashir
Copy link
Author

Change the color and size of the highlighted transcript as per moiz feedback.

Copy link

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saeedbashir
Copy link
Author

@rnr Changes are approved by Moiz offline so I'm merging this so we can create the build for bug bash

@saeedbashir saeedbashir merged commit d5c38e5 into 2U/develop Jul 23, 2024
3 checks passed
@saeedbashir saeedbashir deleted the saeed/highlight_subtitiles branch July 23, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants