Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Define license assign endpoint on Gateway #255

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

sameenfatima78
Copy link
Member

@sameenfatima78 sameenfatima78 commented Dec 14, 2023

This PR adds a definition for license-manager assign endpoint on the Omnibus API to expose it to Gateway.

Host variable is also added to pick up host value for the service. https://github.com/edx/edx-internal/pull/9905

JIRA: https://2u-internal.atlassian.net/browse/ENT-7995

fixed failing tests

added tests
@@ -47,6 +47,8 @@
help="Location of enterprise catalog IDA for request routing")
parser.add_argument('--authoring-host', required=True,
help="Location of Studio for authoring request routing")
parser.add_argument('--license-manager-host', required=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For few args like --enterprise-host it is marked as required=False, how we are figuring this out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch but I guess it's ok to mark it required as long as the stage variables are being served here https://github.com/edx/edx-internal/pull/9905

Copy link
Member

@zamanafzal zamanafzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@sameenfatima78 sameenfatima78 merged commit 60246d7 into master Dec 19, 2023
3 checks passed
@bszabo
Copy link
Contributor

bszabo commented Dec 20, 2023

@sameenfatima78 Good day! Could you please have a look at the build status for the stage-edx-api GoCD pipeline stage? This PR appears to be generating the following error:

botocore.errorfactory.BadRequestException: An error occurred (BadRequestException) when calling the PutRestApi operation: Errors found during import:
	Unable to create model for 'body_1': Model name must be alphanumeric: body_1

I'm interested in merging unrelated changes, so please let me know if I can be of assistance, or, if that's not needed, when I should try my merge.

@sameenfatima78
Copy link
Member Author

@bszabo Hi, Bernard. I'm currently looking into this but haven't made much progress yet. Will let you know if I'm able to figure out the cause otherwise I can revert my changes to unblock you, if required.

@sameenfatima78
Copy link
Member Author

@bszabo Just pushed a fix and the pipeline is all green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants