-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Define license assign endpoint on Gateway #255
Conversation
328a397
to
e58b957
Compare
fixed failing tests added tests
e58b957
to
cfd931a
Compare
@@ -47,6 +47,8 @@ | |||
help="Location of enterprise catalog IDA for request routing") | |||
parser.add_argument('--authoring-host', required=True, | |||
help="Location of Studio for authoring request routing") | |||
parser.add_argument('--license-manager-host', required=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For few args like --enterprise-host
it is marked as required=False
, how we are figuring this out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good catch but I guess it's ok to mark it required as long as the stage variables are being served here https://github.com/edx/edx-internal/pull/9905
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@sameenfatima78 Good day! Could you please have a look at the build status for the
I'm interested in merging unrelated changes, so please let me know if I can be of assistance, or, if that's not needed, when I should try my merge. |
@bszabo Hi, Bernard. I'm currently looking into this but haven't made much progress yet. Will let you know if I'm able to figure out the cause otherwise I can revert my changes to unblock you, if required. |
@bszabo Just pushed a fix and the pipeline is all green now. |
This PR adds a definition for license-manager assign endpoint on the Omnibus API to expose it to Gateway.
Host variable is also added to pick up host value for the service. https://github.com/edx/edx-internal/pull/9905
JIRA: https://2u-internal.atlassian.net/browse/ENT-7995