Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import common deploy package with absolute path #235

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix: import common deploy package with absolute path #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/aws/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import argparse
import logging
from .common.deploy import deploy
from aws.common.deploy import deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the pipeline output. The command run starts like /bin/bash -c "PYTHONPATH=python-libs python3 scripts/aws/deploy.py -. I'm pretty sure this means that the correct statement here would be from scripts.aws.common.deploy import deploy. Try that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts.aws like that doesn't pass pylint.


if __name__ == '__main__':

Expand Down
2 changes: 1 addition & 1 deletion scripts/aws/deploy_studio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import argparse
import logging
from .common.deploy import deploy
from aws.common.deploy import deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment above - from scripts.aws.common.deploy import deploy


if __name__ == '__main__':

Expand Down