fix: import common deploy package with absolute path #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesperhodge
requested changes
Sep 29, 2023
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import argparse | |||
| import logging | |||
| from .common.deploy import deploy | |||
| from aws.common.deploy import deploy | |||
There was a problem hiding this comment.
I looked at the pipeline output. The command run starts like /bin/bash -c "PYTHONPATH=python-libs python3 scripts/aws/deploy.py -. I'm pretty sure this means that the correct statement here would be from scripts.aws.common.deploy import deploy. Try that?
There was a problem hiding this comment.
scripts.aws like that doesn't pass pylint.
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import argparse | |||
| import logging | |||
| from .common.deploy import deploy | |||
| from aws.common.deploy import deploy | |||
There was a problem hiding this comment.
see my comment above - from scripts.aws.common.deploy import deploy
jesperhodge
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: import common deploy package with absolute path
another follow-on attempt to fix the gocd pipeline error that does not occur locally.