-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS is currently centralized, should be componentized? #410
Comments
Related: #409 |
A concrete problematic situation related to this issue: |
Also note that some SVG icons contain non-parameterized inline CSS definitions: For example:
This could cause problems when implementing support for OS high-contrast / dark mode. The solution we will likely implement is CSS "variables" (custom properties), just like ReadiumCSS, at which point the SVG icons might need tweaking too. |
https://github.com/readium/readium-desktop/tree/develop/src/renderer/assets/styles
=> all in one folder, but should be tied to specific JSX component?
The text was updated successfully, but these errors were encountered: