Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hygiene tests update (WIP) #2026

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Hygiene tests update (WIP) #2026

wants to merge 10 commits into from

Conversation

mereolog
Copy link
Contributor

@mereolog mereolog commented Jun 27, 2024

Description

This pull request synchronises the FIBO hygiene tests with those in https://github.com/edmcouncil/idmp.
It assumes that #2021 has been addressed beforehand.

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

mereolog added 7 commits June 24, 2024 12:22
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
@mereolog mereolog added the hygiene Example of general problem which should be picked up by Hygiene tests or a new hygiene test proposal label Jun 27, 2024
@mereolog mereolog added this to the 2024Q2 FIBO Release milestone Jun 27, 2024
@mereolog mereolog self-assigned this Jun 27, 2024
@mereolog mereolog changed the title Hygine test update Hygiene tests update Jun 27, 2024
@mereolog mereolog changed the title Hygiene tests update Hygiene tests update (WIP) Jun 27, 2024
mereolog added 2 commits June 27, 2024 18:20
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Copy link
Contributor

@rivettp rivettp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere we should configure (and allow others to) which tests to be run against which project: I don't think we should assume that IDMP has the same requirements as FIBO. For example I don't think this one should apply to FIBO: etc/testing/hygiene_parameterized/testHygiene_performance_multiple_different_individuals.sparql

@mereolog
Copy link
Contributor Author

In a sense, we do have this option - whatever you put in the project's respective folder (/etc/testing/hygiene_parameterized) will be run, so if we do not want a test we can remove it from this folder.

The particular test you mentioned was explicitly requested by @ElisaKendall, so you should raise your concern with her - but I agree that it does not fit to this particular project.

@ElisaKendall
Copy link
Contributor

In a sense, we do have this option - whatever you put in the project's respective folder (/etc/testing/hygiene_parameterized) will be run, so if we do not want a test we can remove it from this folder.

The particular test you mentioned was explicitly requested by @ElisaKendall, so you should raise your concern with her - but I agree that it does not fit to this particular project.

I'm ok if you remove this one, but we just passed all of them so I don't see the harm in keeping it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hygiene Example of general problem which should be picked up by Hygiene tests or a new hygiene test proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants