-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hygiene tests update (WIP) #2026
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere we should configure (and allow others to) which tests to be run against which project: I don't think we should assume that IDMP has the same requirements as FIBO. For example I don't think this one should apply to FIBO: etc/testing/hygiene_parameterized/testHygiene_performance_multiple_different_individuals.sparql
In a sense, we do have this option - whatever you put in the project's respective folder (/etc/testing/hygiene_parameterized) will be run, so if we do not want a test we can remove it from this folder. The particular test you mentioned was explicitly requested by @ElisaKendall, so you should raise your concern with her - but I agree that it does not fit to this particular project. |
I'm ok if you remove this one, but we just passed all of them so I don't see the harm in keeping it. |
Description
This pull request synchronises the FIBO hygiene tests with those in https://github.com/edmcouncil/idmp.
It assumes that #2021 has been addressed beforehand.
Checklist: