lib/ec_glob: plug leak of nums utarray #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuhdev
reviewed
Jun 12, 2024
src/lib/ec_glob.c
Outdated
| @@ -53,16 +53,20 @@ static const UT_icd ut_int_pair_icd = {sizeof(int_pair),NULL,NULL,NULL}; | |||
| #define STRING_CAT(p, string, end) do { \ | |||
| size_t string_len = strlen(string); \ | |||
| assert(end > p); \ | |||
| if (string_len >= (size_t)(end - p)) \ | |||
| if (string_len >= (size_t)(end - p)) { \ | |||
| utarray_free(nums); \ | |||
There was a problem hiding this comment.
I would say goto cleanup is more preferable, which also frees any pcre2 handles if present.
src/lib/ec_glob.c
Outdated
| strcat(p, string); \ | ||
| p += string_len; \ | ||
| } while(0) | ||
|
|
||
| /* safely add a char to a string then move the pointer to the end */ | ||
| #define ADD_CHAR(string, new_chr, end) do { \ | ||
| if (string + 1 >= end) \ | ||
| if (string + 1 >= end) { \ | ||
| utarray_free(nums); \ |
|
SGTM |
xuhdev
reviewed
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static analysis found a number of leaks through the use of the convenience macros.