Skip to content

Commit

Permalink
runsc: allow port-forwarding with network isolation
Browse files Browse the repository at this point in the history
The security implications by this change are not entirely understood.
At the most basic level, there can now be a port inside the sandbox
that allows a network connection to the outside. Network isolation
should prevent that. In Continuum's case this is fine because the
other end outside the sandbox is expected to encrypt all sensitive data.
  • Loading branch information
derpsteb committed Feb 23, 2024
1 parent 238645f commit 1bbae78
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion runsc/boot/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -1642,7 +1642,7 @@ func (l *Loader) portForward(opts *PortForwardOpts) error {
pair := pf.ProxyPair{To: fdConn}

switch l.root.conf.Network {
case config.NetworkSandbox:
case config.NetworkSandbox, config.NetworkNone:
stack := l.k.RootNetworkNamespace().Stack().(*netstack.Stack).Stack
nsConn, err := pf.NewNetstackConn(stack, opts.Port)
if err != nil {
Expand Down

0 comments on commit 1bbae78

Please sign in to comment.