Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initializer: move cryptsetup image into initializer #1161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmxnzo
Copy link
Contributor

@jmxnzo jmxnzo commented Jan 16, 2025

This PR introduces the two commits of #1132 again, which have been reverted due to the release problems in #1150 .
Until now, we used a specific cryptsetup image, containing a couple of filesystem and mount tools that facilitate the LUKS encryption.
This PR is a first step to include the dependencies of the cryptsetup image in the initializer, while still keeping the bash entry point for now to allow setting up the LUKS device by the initializer. Thus all existing references to the specific cryptsetup image are dropped as part of this PR.

As a follow up the mounting/set up of the encrypted volume done by the bash entrypoint will be moved to a subcommand of the initializer binary.

K3s-QEMU-TDX: https://github.com/edgelesssys/contrast/actions/runs/12748493847
K3s-QEMU-SNP: https://github.com/edgelesssys/contrast/actions/runs/12748490036
AKS-CLH-SNP: https://github.com/edgelesssys/contrast/actions/runs/12748475625

@jmxnzo jmxnzo added the changelog PRs that should be part of the release notes label Jan 16, 2025
@jmxnzo jmxnzo requested a review from katexochen as a code owner January 16, 2025 15:36
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release v1.3.0 is out, so I'd say let's get this reapplied.

The commit history would be a bit easier to understand if you reapplied the commits (i.e., revert the reverts) instead of just rebasing the old branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog PRs that should be part of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants