Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrast-releases: add mysql demo and runtime.yml for metal platforms #1110

Merged
merged 2 commits into from
Dec 31, 2024
Merged

contrast-releases: add mysql demo and runtime.yml for metal platforms #1110

merged 2 commits into from
Dec 31, 2024

Conversation

katexochen
Copy link
Member

We now have both demos in deployment, we'll have to see if that fits our needs.

@katexochen
contrast-releases: add runtime.yml for metal platforms
6f2e197 
Signed-off-by: Paul Meyer <katexochen0@gmail.com>
@katexochen
contrast-releases: add mysql demo
c4d8abf 
Signed-off-by: Paul Meyer <katexochen0@gmail.com>
@katexochen katexochen added no changelog PRs not listed in the release notes backport release/v1.2 labels Dec 30, 2024
@katexochen katexochen requested a review from msanft December 30, 2024 14:30
msanft
msanft approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo and runtime artifacts exist on the release, so LGTM.

@katexochen
Copy link
Member Author

Demo and runtime artifacts exist on the release, so LGTM.

This PR is not about adding them to the release, but consuming the release and providing release artifacts in a nix shell. ;)

@katexochen
Copy link
Member Author

test release: https://github.com/edgelesssys/contrast/actions/runs/12547976345

@katexochen
Copy link
Member Author

test release: https://github.com/edgelesssys/contrast/actions/runs/12547976345

Ah, we can't test this as it uses the script from main.

@katexochen katexochen merged commit e788b4d into main Dec 31, 2024
15 checks passed
@katexochen katexochen deleted the p/release-artif branch December 31, 2024 07:42
@edgelessci edgelessci mentioned this pull request Dec 31, 2024
Merged
@edgelessci
Copy link
Contributor

Successfully created backport PR for release/v1.2:

@katexochen
Copy link
Member Author

Looks like it works as intended: 8fdacf1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanft msanft msanft approved these changes

Assignees
No one assigned
Labels
backport release/v1.2 no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katexochen @edgelessci @msanft