packages/libnvidia-container-custom: init #1089
Open
+334
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msanft
force-pushed
the
msanft/libnvida-container-custom
branch
2 times, most recently
from
b11f561 to
d3cec84
Compare
msanft
changed the title
This adds a custom implementation of libnvidia-container that can resolve binaries (like `nvidia-smi`) correctly on NixOS. This needs to know the location of the binaries. Unfortunately, it is not possible to supply the package build with the correct paths from the Nix store, as the binaries are built in the driver package, which is specific to the host (i.e. the kernel), and thus is only known in the NixOS build, where we already need to have the package, creating a circular dependency. This adds a vendored version of said package with a workaoround that consist of just having it search in the NixOS PATH (i.e. `/run/current-system/sw`), which is fine, since we only use this package in NixOS-scenarios, but can't be upstreamed since it's incompatible with other distributions.
Make `libnvidia-container-custom` the default `libnvidia-container` in our NixOS build.
msanft
force-pushed
the
msanft/libnvida-container-custom
branch
from
d3cec84 to
b1e2cff
Compare
burgerdev
reviewed
Dec 20, 2024
| From 8799541f99785d2bd881561386676fb0985e939e Mon Sep 17 00:00:00 2001 | ||
| From: Moritz Sanft <58110325+msanft@users.noreply.github.com> | ||
| Date: Thu, 10 Oct 2024 14:32:42 +0200 | ||
| Subject: [PATCH] fix library resolving |
There was a problem hiding this comment.
I don't understand why this needs to be fixed in C code. Can't we just symlink the required binaries from an FHS directory?
There was a problem hiding this comment.
Looking at this again, we should be able to get rid from this patch if we patch the PATH of the OCI hook that calls nvidia-container-cli. I will check that.
There was a problem hiding this comment.
We should be able to drop it if we can get rid of this line upstream and use PATH instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a custom implementation of libnvidia-container that can resolve binaries (like
nvidia-smi) correctly on NixOS. This needs to know the location of the binaries. Unfortunately, it is not possible to supply the package build with the correct paths from the Nix store, as the binaries are built in the driver package, which is specific to the host (i.e. the kernel), and thus is only known in the NixOS build, where we already need to have the package, creating a circular dependency. This adds a vendored version of said package with a workaoround that consist of just having it search in the NixOS PATH (i.e./run/current-system/sw), which is fine, since we only use this package in NixOS-scenarios, but can't be upstreamed since it's incompatible with other distributions.