feat!(containers): deployment caching #816
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusergit
force-pushed
the
feat/deployment-caching
branch
from
6c32e43 to
333070b
Compare
davidebriani
requested changes
Feb 10, 2025
backend/lib/edgehog/containers/deployment/types/resources_state.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/types/resources_state.ex
Outdated
Show resolved
Hide resolved
noaccOS
requested changes
Feb 12, 2025
backend/lib/edgehog/containers/deployment/changes/mark_as_starting.ex
Outdated
Show resolved
Hide resolved
backend/lib/edgehog/containers/deployment/changes/mark_as_stopping.ex
Outdated
Show resolved
Hide resolved
lusergit
force-pushed
the
feat/deployment-caching
branch
2 times, most recently
from
898f85d to
b985ba8
Compare
- Decouples the deployment state (created, sent, stopped, stopping, ...) and the underlying resources states (created images, created networks, ...) from each other. - The deployment state gets updated when the device publishes on the appropriate interfaces. Its state is cached and persisted in the DB so we dont have to query the device every time we want to update the deployment resources state. Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
lusergit
force-pushed
the
feat/deployment-caching
branch
from
b985ba8 to
a711257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently deployments are hand-checked each time a device trigger is called. This PR decouples the state of the deployment and the state of the underlying resources and caches the deployment state sent by the device.
This change is breaking as it renames the old
statusattribute of a deployment intostate(to use the same naming schema as the other caching layers, see #812 #813 #814 and #815) and introduces a newresources_stateattribute to signal the fronted the state of the underlying resources related to the deployment. If this PR gets merged the frontend should be upgraded as well.