Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bindings generation from manifest build #6

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

alexcasalboni
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

If you run uv run componentize-py --wit-path wit/ bindings edgee_world when the edgee_world already exists, the command fails, so it can't be chained in the build command).

@alexcasalboni alexcasalboni self-assigned this Feb 14, 2025
@alexcasalboni alexcasalboni requested a review from a team as a code owner February 14, 2025 16:03
@NicolasGirardot
Copy link
Contributor

Nice catch,

@alexcasalboni alexcasalboni merged commit bbd9ff1 into main Feb 14, 2025
1 check passed
@alexcasalboni alexcasalboni deleted the fix-manifest-build branch February 14, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants