Add typescript support #7
Conversation
alexcasalboni
requested review from
KokaKiwi,
CLEMENTINATOR,
SachaMorard,
Jer1605 and
NicolasGirardot
|
Also, @Jer1605 any suggestions to make that code more TS-friendly? I've only converted the typing from the JS implementation, but I'm sure that a native TypeScript implementation would look quite different :) |
| @@ -5,11 +5,13 @@ | |||
| "types": "./types/wit.d.ts", | |||
| "scripts": { | |||
| "build": "npx @bytecodealliance/jco componentize src/index.js --wit wit -o example-js-component.wasm -n data-collection -d all", | |||
| "build-typescript": "npx tsc & npx @bytecodealliance/jco componentize src/typescript/index.js --wit wit -o example-js-component.wasm -n data-collection -d all", | |||
There was a problem hiding this comment.
just for that i think its own repo is a good idea :D
There was a problem hiding this comment.
yeah I had to create another folder because tsc by default compiles index.ts into index.js (overwriting the existing JS file). And then the build script needs the additional tsc step to generate the .js file, so it can't be 100% identical either.
I'd also agree this is enough to justify splitting to its own repo 👍
There was a problem hiding this comment.
@alexcasalboni, I'd definitely recommend splitting TypeScript into its own repo. Mixing JS and TS adds extra build steps and potential conflicts (like overwriting issues), plus not everyone uses TS. Keeping them separate makes things cleaner, easier to maintain, and avoids unnecessary complexity. Sounds like a win-win ;)
|
Closing, in favor of edgee-cloud/example-ts-component#1 |
Not sure if this fits here or if we should have its own repo 🤔
Thoughts?