Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add link to project after a push #208

Closed
wants to merge 1 commit into from
Closed

feat: add link to project after a push #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions crates/cli/src/commands/components/push.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ pub async fn run(opts: Options) -> anyhow::Result<()> {
tracing::info!("Creating component version...");
client
.create_component_version_by_slug()
.org_slug(organization.slug)
.org_slug(organization.slug.clone())
.component_slug(&manifest.package.name)
.body(
api_types::ComponentVersionCreateInput::builder()
Expand All @@ -132,9 +132,12 @@ pub async fn run(opts: Options) -> anyhow::Result<()> {
.api_context("Could not create version")?;

tracing::info!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KokaKiwi is this actually logging to stdout? because I didn't get any confirmation message when pushing 🤔

maybe we should distinguish between tracing and standard logging?

"{} {} pushed successfully!",
"{} {} pushed successfully! You can view it at: https://edgee.cloud/~/{}/component-registry/{}/{}",
manifest.package.name,
manifest.package.version,
organization.slug,
organization.slug,
manifest.package.name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ok to use in the URL? if we get the component slug in the API response, maybe that's a better way

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use the component slug

Copy link
Contributor Author

@NicolasGirardot NicolasGirardot Feb 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm closing back the PR as we might be working with the return method of the update component based on another ticket

manifest.package.version
);

Ok(())
Expand Down