feat: add link to project after a push #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,9 +132,12 @@ pub async fn run(opts: Options) -> anyhow::Result<()> { | |||
| .api_context("Could not create version")?; | |||
|
|
|||
| tracing::info!( | |||
There was a problem hiding this comment.
@KokaKiwi is this actually logging to stdout? because I didn't get any confirmation message when pushing 🤔
maybe we should distinguish between tracing and standard logging?
| manifest.package.name, | ||
| manifest.package.version, | ||
| organization.slug, | ||
| organization.slug, | ||
| manifest.package.name, |
There was a problem hiding this comment.
is this ok to use in the URL? if we get the component slug in the API response, maybe that's a better way
There was a problem hiding this comment.
we should use the component slug
There was a problem hiding this comment.
i'm closing back the PR as we might be working with the return method of the update component based on another ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Describe your changes here
Related Issues
List related issues here