Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new component configuration #199

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

SachaMorard
Copy link
Contributor

@SachaMorard SachaMorard commented Feb 4, 2025

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

This pull request introduces changes to DataCollectionComponents configuration fields.

  • name becomes id
  • component becomes file
  • credentials and config are merged into settings
  • forward_client_headers is removed (it is now a part of the edgee_request object return by components)

These changes affect edgee.toml components part:

[[components.data_collection]]
id = "amplitude" # could be a slug (edgee/amplitude) or an alias (amplitude)
file = "../components/amplitude-component/amplitude.wasm"
settings.amplitude_api_key = "xxxx"
settings.edgee_anonymization = true
settings.edgee_default_consent = "pending"
settings.edgee_track_event_enabled = false
settings.edgee_user_event_enabled = true
settings.edgee_page_event_enabled = true
Other changes:
  • New wit protocol (with forward_client_headers)
  • Openapi.json fixes
  • Readme changes following the new component configuration

Related Issues

List related issues here

@SachaMorard SachaMorard added the enhancement New feature or request label Feb 4, 2025
@SachaMorard SachaMorard force-pushed the feat/new-component-configuration branch from 3b5b0bb to 57e35f4 Compare February 4, 2025 02:34
@SachaMorard SachaMorard marked this pull request as ready for review February 4, 2025 04:15
@SachaMorard SachaMorard requested a review from a team as a code owner February 4, 2025 04:15
Copy link
Contributor

@CLEMENTINATOR CLEMENTINATOR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Copy link
Contributor

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@SachaMorard SachaMorard merged commit 4c377c3 into main Feb 4, 2025
4 checks passed
@SachaMorard SachaMorard deleted the feat/new-component-configuration branch February 4, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants