feat: Add components subcommand #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KokaKiwi
force-pushed
the
feat/cli-component-commands
branch
from
73c413e to
dee49cc
Compare
| tracing::info!("Running: {}", manifest.package.build.command); | ||
| let mut cmd = Command::new("sh"); | ||
| cmd.arg("-c").arg(manifest.package.build.command); | ||
| let status = cmd.status()?; |
There was a problem hiding this comment.
I see that:
By default, stdin, stdout and stderr are inherited from the parent.
Is that ok by default? maybe it shouldn't be logged to stdout unless you set an env variable for debugging?
| } | ||
|
|
||
| #[derive(Debug, Deserialize)] | ||
| pub struct Package { |
There was a problem hiding this comment.
is there anything else that we might want here? like something the web console supports and we don't support yet with the CLI?
maybe the component image/logo?
alexcasalboni
approved these changes
Feb 11, 2025
* feat: add new and init command * feat: update commands * feat: fix clippy * feat: added default build command for the init * feat: update manifest for init with new cattegory and subcat prompt * feat: updated some typos and added logs * feat: add instructions to install dependencies * feat: update command with new manifest * add TypeScript to components boilerplace --------- Co-authored-by: Alex Casalboni <alexsaxmib@gmail.com>
Co-authored-by: Nicolas Girardot <122389871+NicolasGirardot@users.noreply.github.com>
NicolasGirardot
approved these changes
Feb 11, 2025
SachaMorard
approved these changes
Feb 11, 2025
SachaMorard
reviewed
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
edgee componentssubcommandedgee serveRelated Issues