Skip to content

Feature/inheritance #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

Feature/inheritance #85

wants to merge 28 commits into from

Conversation

danovaro
Copy link
Member

@danovaro danovaro commented May 14, 2025

This PR introduces:

  • strict validation is enforced by default
  • introduced aliases for the verbs
  • ability to specify subtypes and a context to asses which subtype has to be used (to handle tigge)
  • metadata validation order is based on the canonical axis order, so that metadata used to match the context are already validated
  • improved date parsing
  • many tests derived from the mars-client migration suite (@tbkr)

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

Attention: Patch coverage is 91.05431% with 56 lines in your changes missing coverage. Please review.

Project coverage is 66.85%. Comparing base (6b41e2f) to head (1361547).

Files with missing lines Patch % Lines
src/metkit/mars/Type.cc 74.57% 15 Missing ⚠️
tests/test_expand.cc 93.42% 15 Missing ⚠️
src/metkit/mars/MarsLanguage.cc 87.03% 7 Missing ⚠️
src/metkit/mars/TypeDate.cc 83.33% 6 Missing ⚠️
tests/test_request.cc 88.00% 3 Missing ⚠️
src/metkit/mars/ContextRule.h 92.30% 2 Missing ⚠️
src/metkit/mars/TypeEnum.cc 90.00% 2 Missing ⚠️
tests/test_date.cc 91.30% 2 Missing ⚠️
src/metkit/mars/MarsRequest.cc 95.45% 1 Missing ⚠️
src/metkit/mars/Parameter.cc 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
+ Coverage    65.90%   66.85%   +0.94%     
===========================================
  Files          122      124       +2     
  Lines         6983     7240     +257     
  Branches       667      708      +41     
===========================================
+ Hits          4602     4840     +238     
- Misses        2381     2400      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants