Add more flexibility to the way we find the ICompositeNode for an object #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzoBettini
approved these changes
Feb 3, 2024
| * | ||
| * @since 2.34 | ||
| * Alternatively, the {@link EObject} might contain an adapter that is for the {@link ICompositeNode ICompositeNode.class} |
There was a problem hiding this comment.
nip: maybe "that is" is redundant?
| } | ||
| if (adapter instanceof INodeReference) { | ||
| return ((INodeReference) adapter).getNode(); | ||
| } |
There was a problem hiding this comment.
Maybe I don't understand the details, but wouldn't this be equivalent to
Adapter adapter = EcoreUtil.getExistingAdapter(object, ICompositeNode.class);
if (adapter instanceof INodeReference) {
return ((INodeReference) adapter).getNode();
}
return (ICompositeNode) adapter;There was a problem hiding this comment.
I wanted to have the instanceof check for the ICompositeNode first since it's far more likely to be true. Doesn't matter in practice so I'll apply your suggestion.
Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
szarnekow
force-pushed
the
sz_nodemodel
branch
from
bb2c510 to
aa284e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.