Xtend: put an error marker on each incompatible exception in overridden method #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it also covers several supertypes, which was not covered before
szarnekow
reviewed
Jan 18, 2024
...pse.xtend.core.tests/src/org/eclipse/xtend/core/tests/validation/OverrideValidationTest.java
Outdated
Show resolved
Hide resolved
szarnekow
approved these changes
Jan 18, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 19, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 22, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 23, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 26, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 30, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2912
The PR also covers the suffix of the error message in case there are several supertypes (this was not covered before).
The markers now look like this:
and the two error messages say