Skip to content

Commit

Permalink
Update to up-rust 0.2.0 (#81)
Browse files Browse the repository at this point in the history
Also pinned pre-release version of Zenoh in order to prevent Cargo
from using a more recent  pre-release which might be incompatible
with the required one.
  • Loading branch information
sophokles73 authored Oct 1, 2024
1 parent 927e2ea commit 1e18a88
Show file tree
Hide file tree
Showing 8 changed files with 127 additions and 342 deletions.
440 changes: 113 additions & 327 deletions Cargo.lock

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ protobuf = { version = "3.3" }
tokio = { version = "1.35.1", default-features = false }
tracing = "0.1.40"
tracing-subscriber = "0.3.18"
up-rust = "0.1.5"
zenoh = { version = "1.0.0-alpha.6", features = ["unstable", "internal"] }
up-rust = "0.2.0"
zenoh = { version = "=1.0.0-beta.3", features = ["unstable", "internal"] }

[dev-dependencies]
chrono = "0.4.31"
Expand Down
2 changes: 1 addition & 1 deletion examples/l2_rpc_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ async fn main() {

// create uPayload and send request
let data = String::from("GetCurrentTime");
let payload = UPayload::new(data.into(), UPayloadFormat::UPAYLOAD_FORMAT_TEXT);
let payload = UPayload::new(data, UPayloadFormat::UPAYLOAD_FORMAT_TEXT);
let call_options = CallOptions::for_rpc_request(
5_000,
Some(UUID::build()),
Expand Down
4 changes: 2 additions & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ enum MessageFlag {
Response,
}

type SubscriberMap = Arc<Mutex<HashMap<(String, ComparableListener), Subscriber<'static, ()>>>>;
type QueryableMap = Arc<Mutex<HashMap<(String, ComparableListener), Queryable<'static, ()>>>>;
type SubscriberMap = Arc<Mutex<HashMap<(String, ComparableListener), Subscriber<()>>>>;
type QueryableMap = Arc<Mutex<HashMap<(String, ComparableListener), Queryable<()>>>>;
type QueryMap = Arc<Mutex<HashMap<String, Query>>>;
type RpcCallbackMap = Arc<Mutex<HashMap<OwnedKeyExpr, Arc<dyn UListener>>>>;
pub struct UPTransportZenoh {
Expand Down
7 changes: 5 additions & 2 deletions src/rpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use up_rust::{
LocalUriProvider, UAttributes, UCode, UMessageType, UPayloadFormat, UPriority, UStatus, UUri,
UUID,
};
use zenoh::{query::QueryTarget, sample::SampleBuilderTrait};
use zenoh::query::QueryTarget;

pub struct ZenohRpcClient {
transport: Arc<UPTransportZenoh>,
Expand Down Expand Up @@ -125,7 +125,10 @@ impl RpcClient for ZenohRpcClient {
..Default::default()
}));
};
Ok(Some(UPayload::new(sample.payload().into(), payload_format)))
Ok(Some(UPayload::new(
sample.payload().into::<Vec<u8>>(),
payload_format,
)))
}
Err(e) => {
let msg = format!("Error while parsing Zenoh reply: {e:?}");
Expand Down
1 change: 0 additions & 1 deletion src/utransport.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ use up_rust::{
};
use zenoh::{
key_expr::keyexpr,
prelude::*,
query::{Query, QueryTarget, Reply},
sample::Sample,
};
Expand Down
4 changes: 2 additions & 2 deletions tests/l2_rpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ impl RequestHandler for ExampleHandler {
assert_eq!(data, self.request_data);
// return
let payload = UPayload::new(
self.response_data.clone().into(),
self.response_data.clone(),
UPayloadFormat::UPAYLOAD_FORMAT_TEXT,
);
Ok(Some(payload))
Expand Down Expand Up @@ -91,7 +91,7 @@ async fn test_l2_rpc() {
// Create L2 RPC client
let rpc_client = Arc::new(ZenohRpcClient::new(uptransport_client.clone()));

let payload = UPayload::new(request_data.into(), UPayloadFormat::UPAYLOAD_FORMAT_TEXT);
let payload = UPayload::new(request_data, UPayloadFormat::UPAYLOAD_FORMAT_TEXT);
let call_options = CallOptions::for_rpc_request(5_000, None, None, None);
let result = rpc_client
.invoke_method(
Expand Down
7 changes: 2 additions & 5 deletions tests/rpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,7 @@ async fn test_rpc_server_client(
{
let rpc_client = Arc::new(ZenohRpcClient::new(uptransport_client.clone()));

let payload = UPayload::new(
request_data.clone().into(),
UPayloadFormat::UPAYLOAD_FORMAT_TEXT,
);
let payload = UPayload::new(request_data.clone(), UPayloadFormat::UPAYLOAD_FORMAT_TEXT);
let call_options = CallOptions::for_rpc_request(
5_000,
Some(UUID::build()),
Expand Down Expand Up @@ -183,7 +180,7 @@ async fn test_rpc_server_client(

// Send request
let umessage = UMessageBuilder::request(sink_uuri.clone(), src_uuri.clone(), 1000)
.build_with_payload(request_data.clone(), UPayloadFormat::UPAYLOAD_FORMAT_TEXT)
.build_with_payload(request_data, UPayloadFormat::UPAYLOAD_FORMAT_TEXT)
.unwrap();
uptransport_client.send(umessage).await.unwrap();

Expand Down

0 comments on commit 1e18a88

Please sign in to comment.