Move InMemorySubscriber from L2 to L3 client module #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neelam-kushwah
commented
Jul 18, 2024
•
neelam-kushwah
commented
- Bug fix: The on_receive method in the UListener class has been updated to be asynchronous. This change resolves an issue in the request handler where responses were sent using the asynchronous send API without being awaited, resulting in failures to receive the response. By making the on_receive method asynchronous, the send API is now properly awaited, thereby fixing the response handling issue.
- Moved InMemorySubscriber from L2 communication to L3 client module
- Bump version to 0.2.0 for major release introducing L2 and L3
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
uprotocol/client/usubscription/v3/inmemoryusubcriptionclient.py
Outdated
Show resolved
Hide resolved
uprotocol/client/usubscription/v3/inmemoryusubcriptionclient.py
Outdated
Show resolved
Hide resolved
|
Code coverage report is ready! 📈
|
|
LGTM |
DivyaVuppala
approved these changes
Jul 22, 2024
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
subscription_service
branch
from
3b86b97 to
b4dac12
Compare
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
stevenhartley
requested changes
Jul 24, 2024
uprotocol/client/usubscription/v3/inmemoryusubcriptionclient.py
Outdated
Show resolved
Hide resolved
uprotocol/client/usubscription/v3/inmemoryusubcriptionclient.py
Outdated
Show resolved
Hide resolved
|
Code coverage report is ready! 📈
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.