Skip to content
This repository has been archived by the owner on Jan 20, 2025. It is now read-only.

2nd Eclipse Tractus-X Community Days Contribution #79

Closed
wants to merge 888 commits into from
Closed

2nd Eclipse Tractus-X Community Days Contribution #79

wants to merge 888 commits into from

Conversation

ClosedSourcerer
Copy link
Contributor

@ClosedSourcerer ClosedSourcerer commented May 22, 2024

Description

  • Increased Deployability
  • Fixed minor Issues
  • TRG 8 will be taken care off with a seperate PR into the Upstream Repository.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Bailonis and others added 30 commits November 24, 2023 12:55
# Conflicts:
#	demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/StatusManagerImpl.java
This reverts commit 8e74ac3, reversing
changes made to 3bb827c.
* Added Configure Alert Modal
* Added Configured Alerts table
* Added Triggered Alerts table
* Adjusted the alerts count on the top menu
Copy link

gitguardian bot commented Jun 5, 2024

⚠️ GitGuardian has uncovered 45 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8832579 Assigned Generic High Entropy Secret bff0e3a demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
8832579 Assigned Generic High Entropy Secret 9645c2c demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
8832579 Assigned Generic High Entropy Secret bff0e3a demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
8832579 Assigned Generic High Entropy Secret 8562b25 demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
9243936 Assigned Generic High Entropy Secret 7dc89df demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
9243936 Assigned Generic High Entropy Secret 9645c2c demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
9243936 Assigned Generic High Entropy Secret 8320fa9 demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
9044680 Assigned Generic High Entropy Secret 4637e1d demand-capacity-mgmt-backend/src/main/resources/application.yml View secret
9044680 Assigned Generic High Entropy Secret fbfffa0 demand-capacity-mgmt-backend/src/main/resources/application.yml View secret
8835346 Assigned Generic High Entropy Secret 39638f3 charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 78bdc1b charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 7336636 charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 7109ba7 charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret e611903 charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 03f379a charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret e611903 charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 686ddc7 charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 9949ae3 charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 78bdc1b charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 5396300 charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 913b9a2 charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 6c46efa charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 751868a charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 6c46efa charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 5f07c25 charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 35ad4ff charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 5f07c25 charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret b6cb6b3 charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 5af100b charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 11a402c charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 5af100b charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret b6cb6b3 charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 35ad4ff charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret b85f9b6 charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 9949ae3 charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 751868a charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 913b9a2 charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 887ba2f charts/edc/chart/values.yaml View secret
8835346 Assigned Generic High Entropy Secret b85f9b6 charts/edc/consumer/values.yaml View secret
8781932 Assigned Hashicorp Vault Token a45923d .env View secret
8781932 Assigned Hashicorp Vault Token b85f9b6 env View secret
8781932 Assigned Hashicorp Vault Token 6c46efa env View secret
8781932 Assigned Hashicorp Vault Token 4688fc8 env View secret
8781932 Assigned Hashicorp Vault Token 9126b44 env View secret
8813285 Assigned Hashicorp Vault Token 03f379a charts/edc/chart/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nitin-vavdiya
Copy link
Contributor

Please fix failing ECA check.
Also update DEPENDENCIES_BACKEND file as it seems that new deps has been added.

Thanks for reviewing this PR. Regarding DEPENDENCIES_BACKEND, it will be added with this PR

Sorry to disagree, but if you introduce a new dependency with a PR, you need to update the DEPENCENCIES file accordingly. A reference to another PR is not valid.

After rebasing with the main branch we have the correct version of netty-resolver-dns-native-macos in the dependencies file. Let me know if we need further adjustment

@nitin-vavdiya
Copy link
Contributor

GitGuardian seems false positive or not part of this PR, can we rerun the scan or ignore it?

Copy link

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are suddenly 888 commits showing, could you please clean this up?
That's probably also the reason why GitGuardian comes up with those findings and once that's clean up, I assume the finding will be gone.
But in general, if GitGuardian reveals findings they need to documented as what they are in the incident management section (either real - and in that case they need to revoked immediately - or false positive/test) of GitGuardian.

Also, please re-request the review once there should be reviewed again, otherwise reviewers can't be aware that the pull request should be reviewed again.

@nitin-vavdiya
Copy link
Contributor

There are suddenly 888 commits showing, could you please clean this up? That's probably also the reason why GitGuardian comes up with those findings and once that's clean up, I assume the finding will be gone. But in general, if GitGuardian reveals findings they need to documented as what they are in the incident management section (either real - and in that case they need to revoked immediately - or false positive/test) of GitGuardian.

Also, please re-request the review once there should be reviewed again, otherwise reviewers can't be aware that the pull request should be reviewed again.

I think I mashed up with the PR and sorry for that
"There are suddenly 888 commits showing" > I rebased this PR that's why I think
Does closing this PR and creating fresh PR from my owned form repo make sense?

@evegufy
Copy link

evegufy commented Jul 2, 2024

There are suddenly 888 commits showing, could you please clean this up? That's probably also the reason why GitGuardian comes up with those findings and once that's clean up, I assume the finding will be gone. But in general, if GitGuardian reveals findings they need to documented as what they are in the incident management section (either real - and in that case they need to revoked immediately - or false positive/test) of GitGuardian.
Also, please re-request the review once there should be reviewed again, otherwise reviewers can't be aware that the pull request should be reviewed again.

I think I mashed up with the PR and sorry for that "There are suddenly 888 commits showing" > I rebased this PR that's why I think Does closing this PR and creating fresh PR from my owned form repo make sense?

Hi @nitin-vavdiya rebasing with 800 + commits to drop can be tedious, opening a new pull request is fine (please reference to this one in the description so that we don't loose the discussions).

@nitin-vavdiya
Copy link
Contributor

There are suddenly 888 commits showing, could you please clean this up? That's probably also the reason why GitGuardian comes up with those findings and once that's clean up, I assume the finding will be gone. But in general, if GitGuardian reveals findings they need to documented as what they are in the incident management section (either real - and in that case they need to revoked immediately - or false positive/test) of GitGuardian.
Also, please re-request the review once there should be reviewed again, otherwise reviewers can't be aware that the pull request should be reviewed again.

I think I mashed up with the PR and sorry for that "There are suddenly 888 commits showing" > I rebased this PR that's why I think Does closing this PR and creating fresh PR from my owned form repo make sense?

Hi @nitin-vavdiya rebasing with 800 + commits to drop can be tedious, opening a new pull request is fine (please reference to this one in the description so that we don't loose the discussions).

New PR : #102
@Phil91 We can close this PR

@evegufy evegufy closed this Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.