[GTK4] Migrate deprecated ColorChooser to ColorDialog #1629
Conversation
|
GTK3:
GTK4:
|
bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ColorDialog.java
Outdated
Show resolved
Hide resolved
| // TODO The ColorDialog API doesn't support setting a custom palette | ||
| // See https://gitlab.gnome.org/GNOME/gtk/-/issues/5936 | ||
| // > The new GtkColorDialog api doesn't have this feature atm. We might | ||
| // > want to bring it back, but judging from application use of color | ||
| // > choosers, setting custom palettes is not very popular. |
There was a problem hiding this comment.
This is probably really bad. But as mentioned in the linked issue, as well as the documentation, there is simply no way to customize the palette.
Meaning this is probably something that would first have to be implemented, but I don't think my GTK knowledge is sufficient to do so. :/
There was a problem hiding this comment.
I think we should merge this one as there is not much to be done from SWT side.
There was a problem hiding this comment.
Sounds good to me. I fear that contributing the palette customization directly to GTK is beyond my capabilities, so the current state has to suffice for now.
ptziegler
force-pushed
the
gtk4-color-dialog
branch
from
7a4a404 to
6cd388f
Compare
HannesWell
force-pushed
the
gtk4-color-dialog
branch
from
6cd388f to
c5f57d4
Compare
|
Would you please rebase on master and remove the draft if you agree that it's time to get this one in. |
The Color Chooser has been moved to the GTK3 class and all references inside the GTK4 blocks have been updated to use the new API. Note that the GTK4 API doesn't provide the means to set a custom palette, meaning that the colors specified with setRGBS(RGB[]) are effectively ignored.
ptziegler
force-pushed
the
gtk4-color-dialog
branch
from
c5f57d4 to
f041bb4
Compare
I only wanted to revisit the issue with the modal dialog but that has now been fixed. I don't see any (additional) warnings when trying out the snippets so I think this is done for now. |
|
There is one fundamental problem - the gtk_color_dialog calls are guarded with if( GTK4) blocks but they are introduced in gtk 4.10 so these symbols will simply fail to load (hard crash) if swt is run on gtk 4.0-4.8. |
|
Now I realize I missed the same problem in #1583 so we will have to redo it too. |
I was just about to ask about the Font/Dialog chooser. I can have a look at it over the weekend. |
The Color Chooser has been moved to the GTK3 class and all references inside the GTK4 blocks have been updated to use the new API.
Note that the GTK4 API doesn't provide the means to set a custom palette, meaning that the colors specified with setRGBS(RGB[]) are effectively ignored.