Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No wait on immediate bridge reload #2926

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

No wait on immediate bridge reload #2926

wants to merge 1 commit into from
+3 −1

Conversation

abiliojr
Copy link
Contributor

@abiliojr abiliojr commented Oct 18, 2023 •
edited
Loading

Currently there are 2 kinds of bridge configuration reload: lazy and immediate. According to the readme, immediate "forces a reconnection and so uses the new configuration straight away", but the current implementation first backs off. This pull request skips that first backoff.

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

@abiliojr abiliojr mentioned this pull request Oct 18, 2023
Open
@ralight ralight force-pushed the develop branch 3 times, most recently from 028adb2 to 604b69a Compare March 26, 2024 12:43
@abiliojr
Fix immediate bridge reload
587b105 
Currently bridge connections will backoff even when set to immediate.
This change makes the first attempt to reconnect happen without wait.

On failure, backoff will apply as usual.

Signed-off-by: Abilio Marques <abiliojr@gmail.com>
@ralight ralight force-pushed the develop branch 3 times, most recently from b7e2d3d to e715b04 Compare October 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abiliojr