Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for multiple assignments takes rewrite actions into account now #1766

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Validation for multiple assignments takes rewrite actions into account now #1766

merged 7 commits into from
Dec 11, 2024

Conversation

JohannesMeierSE
Copy link
Contributor

Fixes #1756.

This PR contributes the following improvements for the validation for multiple assignments with = instead of += (see #1412):

  • unassigned actions don't create new objects, only rewrite actions create new objects
  • respect looped rewrite actions, even when they are deeply nested or occur as top-level elements of rules
  • handle asymmetric use of rewrite actions in alternatives

Beyond that, this PR ...

  • simplified the validation logic
  • improved error logging in test utils

@JohannesMeierSE JohannesMeierSE mentioned this pull request Dec 3, 2024
Closed
@cdietrich cdietrich requested a review from msujew December 4, 2024 05:17
@cdietrich
Copy link
Contributor

checked with my usecase in the arithmetics grammar + in the extension host and it seems to work

sailingKieler
sailingKieler approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@sailingKieler sailingKieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM! Just a few remarks and questions, nothing to be changed urgently. 🚀

packages/langium/test/grammar/grammar-validator.test.ts Show resolved Hide resolved
packages/langium/src/grammar/validation/validator.ts Outdated Show resolved Hide resolved
packages/langium/src/grammar/validation/validator.ts Show resolved Hide resolved
packages/langium/src/grammar/validation/validator.ts Outdated Show resolved Hide resolved
@sailingKieler
Copy link
Contributor

And explicit kudos for your elaborate test cases!

@JohannesMeierSE
Copy link
Contributor Author

Thanks for your review @sailingKieler! In my eyes, this PR is ready to merge.

@JohannesMeierSE JohannesMeierSE merged commit e004619 into main Dec 11, 2024
5 checks passed
@spoenemann spoenemann deleted the jm/1756-validation-fix-multiple-rewrites branch December 18, 2024 07:33
msujew pushed a commit that referenced this pull request Jan 23, 2025
@JohannesMeierSE @msujew
Validation for multiple assignments takes rewrite actions into accoun…
e6c58c7 
…t now (#1766)

* recursively take created objects in groups/alternatives into account, added some more specific test cases
* simplified and reworked the validation to support actions as top-level elements in parser rules as well (was another bug)
* derived test cases from the discussion in #1756
* refactoring: inlined method
* improved error logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sailingKieler sailingKieler sailingKieler approved these changes

@cdietrich cdietrich Awaiting requested review from cdietrich

@msujew msujew Awaiting requested review from msujew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in grammar multiple assignments validation
3 participants
@JohannesMeierSE @cdietrich @sailingKieler