Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support users to replace parser rules which are used only as type for cross-references by type declarations #1391

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Support users to replace parser rules which are used only as type for cross-references by type declarations #1391

wants to merge 11 commits into from

Conversation

JohannesMeierSE
Copy link
Contributor

@JohannesMeierSE JohannesMeierSE commented Feb 29, 2024 •
edited
Loading

This PR contributes the following things and closes #1309:

  • At the moment parser rules which are used not for parsing but whose type is used in cross-references are marked as "unused" for users. This message is not accurate and could confuse inexperienced users. Therefore, the message of the validation is improved to "This parser rule is not used for parsing, but referenced by cross-references. Consider to replace this rule by a type declaration.". See Parser rule used as type for cross-reference is marked as "unused" #1309 for details.
  • Additionally, a quick-fix is provided for users to replace such a parser rule by a type declaration.
  • While the two contributions above target a quite special case, this PR contributes also a generic helper functionality to check quick-fixes (testQuickFix in packages/langium/src/test/langium-test.ts). This function is tested by applying it to the mentioned new quick-fix for the Langium grammar.

@JohannesMeierSE JohannesMeierSE force-pushed the validation-unused-rule-crossreference branch from 59cd7b0 to 136a1f9 Compare March 8, 2024 14:51
@JohannesMeierSE
more accurate validation hint for parser rules which are not used for…
01a6486 
… parsing, but for cross-references eclipse-langium#1309
@JohannesMeierSE
first working WIP version for a quick-fix for eclipse-langium#1309
0529f39
@JohannesMeierSE
created own file with test cases for quick-fixes eclipse-langium#1309
9c556fe
@JohannesMeierSE
started validation for parser rules used only for cross-references wi…
dbc9a59 
…th explicitly inferred type

- including a WIP fix for InferredTypes in the grammar
@JohannesMeierSE
additional fixes after rebasing
8b34500
@JohannesMeierSE
introduced helper function for testing quick-fixes, improved code qua…
0990f55 
…lity and comments
@JohannesMeierSE
moved test utility into dedicated file
c217ae0
@JohannesMeierSE
added another test case, refactorings
3c8fc02
@JohannesMeierSE
renamings, simplified test data
8276fc8
@JohannesMeierSE
removed unclear support for UnorderedGroups for now
882aad9
@JohannesMeierSE
added another test, simplified test infrastructure, fixed linting issue
b05bcac
@JohannesMeierSE JohannesMeierSE force-pushed the validation-unused-rule-crossreference branch from 136a1f9 to b05bcac Compare October 8, 2024 11:41
@JohannesMeierSE
Copy link
Contributor Author

FYI: I just resolved conflicts with main. This PR is ready to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parser rule used as type for cross-reference is marked as "unused"
1 participant
@JohannesMeierSE