-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation against function call recursion #1019 #1296
Merged
spoenemann
merged 11 commits into
eclipse-langium:main
from
hpopov:feature/Recursion-should-not-be-allowed-in-arithmetics-1019
Nov 22, 2023
Merged
Add validation against function call recursion #1019 #1296
spoenemann
merged 11 commits into
eclipse-langium:main
from
hpopov:feature/Recursion-should-not-be-allowed-in-arithmetics-1019
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I have only a few minor remarks.
examples/arithmetics/src/language-server/arithmetics-validator.ts
Outdated
Show resolved
Hide resolved
examples/arithmetics/src/language-server/arithmetics-validator.ts
Outdated
Show resolved
Hide resolved
examples/arithmetics/src/language-server/arithmetics-validator.ts
Outdated
Show resolved
Hide resolved
Along the way: - Remove redundant if-clause in evalExpr() - Ensure only definitions are picked in checkUniqueDefinitions() (relying on name property creates a potential bug for future arithmetics grammar extensions) - Remove else clause in bfsStep(): if parent has not been traversed before, it should be traversed even if it has a cyclic call to itself
'::' has no meaning in arithmetics DSL
spoenemann
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1019.
Recursion validation implemented using BFS algorithm for nested function calls as graph nodes.
Implemented scenarios:
def fun1(x): fun1(x);
Here every affected call in the cycle gets a validation error (fun1::fun2, fun2::fun4, and fun4::fun1). In case a function B is called several times from a function A, only first call instance is marked with error (e.g., only first fun1::fun2).
example/recursions.calc
.