JsonSerializer: Support references to other documents #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
force-pushed
the
serialize-uris
branch
from
a2a870b to
6092ddf
Compare
sailingKieler
approved these changes
Nov 8, 2023
| if (this.ignoreProperties.has(key)) { | ||
| return undefined; | ||
| } else if (isReference(value)) { | ||
| const refValue = value.ref; | ||
| const $refText = refText ? value.$refText : undefined; | ||
| if (refValue) { | ||
| const targetDocument = getDocument(refValue); | ||
| let targetUri = ''; | ||
| if (this.currentDocument && !UriUtils.equals(this.currentDocument.uri, targetDocument.uri)) { |
There was a problem hiding this comment.
Maybe more of curiosity: Do you see a case this.currentDocument !== targetDocument is not sufficient/correct?
There was a problem hiding this comment.
Hm, rethinking this, not really. In general, equal URIs implies equal documents.
Yes that makes sense, I forgot that. |
|
@spoenemann i wonder if we can make this configurable |
|
Yes you can pass in a |
|
thx. was a test data error anyway. works as expected if that one is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the JsonSerializer assumes that all cross-references point to nodes in the same document. This change adds support for references to other documents by including the document URI in the
$refstring.