Add SuggestionSearch for Specification

[wba2hi]

Closes: #16

[wba2hi]

Implemented it for "non-specification"-mode as well.
For the "non-specification"-mode the suggestions are taken from the DataBroker itself instead of using VssVehicle().heritage.
This has the positive sideeffect, that if the DataBroker is started with a custom VSS Specification (e.g. vss-extended.json -> https://github.com/SoftwareDefinedVehicle/iveco-scratchpad/blob/main/data/vss-extended.json) the new paths are recognized automatically

For "non-specification"-mode it MUST still be possible to enter any text as a VSS Path. No hard constraints here. This should be taken into account when testing

[Chrylo]

Love the new disconnect icon. :)

[Chrylo]

• Awesome but can we easily align the borders so that they have the same rounded ones? Also the width should align. :)
• Also if we have no result the UI still shows a small margin between the boxes. We can live with this if it is a pain to fix.

[Chrylo]

Switching between the modes is a bit slow now. May be something we can't do much about with the amount of data to auto complete.

[Chrylo]

In specification mode the initial content is empty. May we can already show the first element? Probably related to the fact that we are truncating the "Vehicle" for the elements to save some space. I think we should revert this to be consistent with the VSS mode. The search also seems to be influenced by this.

[Chrylo]

value.indexOf(".")
Can we give this a variable name? :)

[wba2hi]

Can you elaborate on this, e.g. an example on how you think it might look better?

var value = "..."
var index = value.indexOf(".")
while (index > -1) {
   value = value.substringBeforeLast(".")
   pathSet.add(value)

   index = value.indexOf(".") 
}

This should work but feels redundant.

I think if we encapsulate the logic in a separate method as suggested by you the "perceived complexity" should also be reduced. Maybe that's already sufficient?

[Chrylo]

Yes, that looks fine. Could be OK for now to keep the createVssPathHierarchy inside the Activity class but maybe we could write an extension for the GetResponse or List<Types.DataEntry> to convert it into a VssPathHierarchy TreeSet? The activity class is already growing :)

[wba2hi]

I don't like an extension for "GetResponse" because this is pretty unspecific (I would go for it as a last resort). I don't like an extension for "List<Types.DataEntry>" because this feels overspecific (I really hate List-Extensions for some reason)
Do you think it might make sense to maybe expose this function simply as a public API from DataBrokerConnection?

[Chrylo]

Maybe this is more like a "generateSuggestions(List)" method. Then we could put it into the ViewModel?We could even think about creating a VssPath model to make it more clearer where the suggestions are generated from because the algorithm is explicitly checking for "." to split (optional or something for the future).

[wba2hi]

* Awesome but can we easily align the borders so that they have the same rounded ones? Also the width should align. :)

Done

* Also if we have no result the UI still shows a small margin between the boxes. We can live with this if it is a pain to fix.

I tried some stuff, but eventually I left it as is. The issue is, that we only check for expansion of the "Suggestions-Card" and not if there are any elements in it thus showing an "empty-view" with it's paddingTop which creates this gap. If we want to check if the filter returns a non-empty collection we need to move it outside of the LazyListScope, however this makes the UI behave more sluggish.

[wba2hi]

Switching between the modes is a bit slow now. May be something we can't do much about with the amount of data to auto complete.

I see what you mean. I removed the AnimatedContent and the content is there "instantaneously", can you check it again please? To be honest I think the AnimatedContent makes it feel more like it is lagging, than offers a "nice animation" (at least on my Pixel 3)

[Chrylo]

Good Look & Feel LGTM

Tested the search which fits our expectations (for now).