feature: Publish to OSSRH / MavenCentral #47
Conversation
Closes: eclipse-kuksa#46 Signed-off-by: Andre Weber <andre.weber3@etas.com>
| ORG_GPG_PASSPHRASE: ${{ secrets.ORG_GPG_PASSPHRASE }} | ||
| ORG_GPG_PRIVATE_KEY: ${{ secrets.ORG_GPG_PRIVATE_KEY }} | ||
| ORG_OSSRH_PASSWORD: ${{ secrets.ORG_OSSRH_PASSWORD }} | ||
| ORG_OSSRH_USERNAME: ${{ secrets.ORG_OSSRH_USERNAME }} |
There was a problem hiding this comment.
To be honest I have no clue, what happens with our fork once this branch is merged.
Since we don't have these secrets in the Bosch Global Organisation the workflow might start failing when this workflow is executed "locally" on our Bosch Global fork?
There was a problem hiding this comment.
Due to this, it's also quite hard to test this in any other way than simply merging it and checking if it succeeds?
There was a problem hiding this comment.
Skipping deployment now when enot in eclipse-kuksa orga as described here: https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution#example-only-run-job-for-specific-repository
| } | ||
| } | ||
|
|
||
| gradle.taskGraph.whenReady { |
There was a problem hiding this comment.
Can we rewrite this more like this so it does not loop through all the tasks even if it already found the correct task?
Maybe also add some println for information that the signing is disabled here :)
gradle.taskGraph.whenReady {
tasks.withType(Sign::class) {
val publishToMavenLocalTask = allTasks.find { "publishToMavenLocal" in it.name }
var isPublishingToMavenLocal = publishToMavenLocalTask != null
onlyIf { !isPublishingToMavenLocal }
}
}
Closes: #46