fix: Fix exception on empty VssDefinition asset file #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the VssDefinition annotation is missing but the processor is executed then the necessary asset file can't be found. - Removes a redundant `maven-publish` plugin close eclipse-kuksa#43 Signed-Off-By: Mark Hüsers <mark.huesers@etas.com>
Signed-Off-By: Mark Hüsers <mark.huesers@etas.com>
The current loadAssets workaround will result into a ksp error if only tasks like kspDebug are executed. The reason is that the build folder does not have the information from the assets folder (from the tests or apps build command) yet.
|
Can be tested inside the SDK via: |
|
This is still only "improving" the workaround. The real fix will be done here: #45 |
SebastianSchildt
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the VssDefinition annotation is missing but the processor is executed then the necessary asset file can't be found.
The current loadAssets workaround will result into a ksp error if
only tasks like kspDebug are executed. The reason is that the build
folder does not have the information from the assets folder (from
the tests or apps build command) yet.
maven-publishpluginclose #43