Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on Gradle 8.5 to avoid multiple daemons at test runtime. #3373

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Feb 1, 2025

The related jobs

The related Eclipse/JDK issue - eclipse-jdt/eclipse.jdt.core#3385
I have updated the jdt-ls-master and jdt-ls-pr jobs.
The latest 5+ builds are successful.

@snjeza
Copy link
Contributor Author

snjeza commented Feb 1, 2025

test this please

@snjeza snjeza changed the title [WIP] Fix Java LS tests Fix Java LS tests Feb 1, 2025
@snjeza snjeza removed the in progress label Feb 1, 2025
@rgrunber rgrunber added this to the End February 2025 milestone Feb 1, 2025
@@ -108,7 +108,7 @@
<artifactItem>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.32</version>
<version>1.18.36</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, when I do things like redhat-developer/vscode-java#3939, I should probably bump this as well. Thanks 👍

@rgrunber
Copy link
Contributor

rgrunber commented Feb 3, 2025

@snjeza I remember doing some of these bumps (7.3.3 -> 8.5) as part of #3358 , but I decided against doing everything because I thought it would still be nice to test other versions of Gradle. Do you know why the older versions have issues in the test runtime ?

@snjeza
Copy link
Contributor Author

snjeza commented Feb 3, 2025

@rgrunber More versions can start more gradle daemons that can cause SIGKILL.

@snjeza
Copy link
Contributor Author

snjeza commented Feb 3, 2025

The related issue - #1876

@rgrunber rgrunber changed the title Fix Java LS tests Standardize on Gradle 8.5 to avoid multiple daemon's at test runtime. Feb 3, 2025
- Update Lombok used in test runtime (1.18.36)

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
@rgrunber rgrunber changed the title Standardize on Gradle 8.5 to avoid multiple daemon's at test runtime. Standardize on Gradle 8.5 to avoid multiple daemons at test runtime. Feb 3, 2025
@rgrunber rgrunber merged commit 9c5287e into eclipse-jdtls:master Feb 3, 2025
7 checks passed
@rgrunber
Copy link
Contributor

rgrunber commented Feb 4, 2025

@snjeza Still occasionally failing ? https://ci.eclipse.org/ls/job/jdt-ls-master/2208/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants