Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradle 8.8 to compatibility check #3212

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add Gradle 8.8 to compatibility check #3212

merged 1 commit into from
Aug 7, 2024

Conversation

mataha
Copy link
Contributor

@mataha mataha commented Jul 5, 2024

Fixes imports with Java 22 and Gradle 8.8, analogous to #3044.

@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@jdneo
Copy link
Contributor

jdneo commented Jul 8, 2024

Change looks good. Could you check the legal agreements: https://api.eclipse.org/git/eca/status/gh/eclipse-jdtls/eclipse.jdt.ls/3212?

@rgrunber
Copy link
Contributor

@mataha, thanks for creating this. You need to sign the Eclipse Contributor Agreement for us to merge this. See https://www.eclipse.org/legal/ecafaq.php for more details on this.

Log into the Eclipse projects forge (you will need to create an account with the Eclipse Foundation if you have not already done so); click on "Eclipse Contributor Agreement"; and Complete the form. Be sure to use the same email address when you register for the account that you intend to use on Git commit records.

Fixes imports with Java 22 and Gradle 8.8, analogous to #3044.

Signed-off-by: Mateusz Kazimierczuk <mataha+eclipse@protonmail.com>
@mataha
Copy link
Contributor Author

mataha commented Aug 6, 2024

Done.

@rgrunber rgrunber added this to the End August 2024 milestone Aug 7, 2024
@rgrunber rgrunber added the gradle label Aug 7, 2024
@rgrunber rgrunber merged commit 353d49f into eclipse-jdtls:master Aug 7, 2024
5 checks passed
@mataha mataha deleted the fix/gradle-8.8 branch August 7, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants