-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove Json-Ld requirement for version endpoint and add version schema #67
feat: Remove Json-Ld requirement for version endpoint and add version schema #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for me to clearly understand this. Removal of the JSON-LD context for the version metadata is primarily in order to ensure stability of the version metadata, as this spans multiple versions in one go. Therefore it might introduce issues when the context changes over the versions?
If that is the case, should we then include the version of the JSON schema? This might introduce issues when we actually want to change the schema of the version metadata.
Yes, exactly. Do you have a proposal for including the schema version? I can adapt the PR to include it. |
What we might do is require the
We still then have to take care of ensuring the schema is stable, perhaps by using |
@mkollenstart Do you want to file a separate issue so that we can explore this in more detail? If you are OK with that approach, should we merge this? |
@mkollenstart I'm going to merge this and we can file a separate issue. |
dd2a75f
into
eclipse-dataspace-protocol-base:main
What this PR changes/adds
We can't version the version endoint. Therefore, we need to remove the Json-Ld requirement.
Linked Issue(s)
Closes #37