-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for VobSub subtitles #11
Conversation
1f866d3
to
58566f3
Compare
6f0db74
to
ff13a20
Compare
@timj If you don't mind, before I merge, would you try running this on a handful of you VobSub subtitle format files. This PR won't support reading them from Matroska files, but I will add that in a future PR. I just want to see how accurate this is for more than just the handful of files I have thrown at it. |
fe2d90a
to
01d833c
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
I will be happy to take a look this evening. |
First attempt:
with subs.tar.gz |
Whelp, this is why I'm glad I waited to merge. I'll try to look into this again this evening and see if I can figure out what I need to do to fix it. |
07a1844
to
bb48698
Compare
Alright, I think I fixed that file at the very least, give it a try now @timj. I do have to say, I appreciate your taste in movies based off of that subtitle file. |
This currently only tries to decode even lines, and doesn't always work properly. Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
For some reason the VobSub tests seem to hang forever while running in the Actions Environment. For now we will skip them as they are passing when run locally. Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Thanks. That works for me. Much better quality than I get out of Subtools with Tesseract so that's a bonus. I can try some more examples over the weekend. |
Glad to hear it! That's actually what drew me to want to do this originally, the fact that the macOS OCR API seems to be really good. |
This will only add support for VobSub stream decoding for the moment.
In the future additional support will be implemented for extracting the
stream from an input
.mkv
file like has been done with PGS subtitlestreams already.
For now this focuses on simply adding functionality for the basic VobSub
format without any extra bells or whistles.